After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 321790 - [mpegstream] improve packetize to detect incorrect data
[mpegstream] improve packetize to detect incorrect data
Status: RESOLVED INCOMPLETE
Product: GStreamer
Classification: Platform
Component: gst-plugins-ugly
git master
Other Linux
: Normal enhancement
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2005-11-18 10:04 UTC by Josef Zlomek
Modified: 2009-09-09 17:19 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch to skip incorrect data (3.36 KB, patch)
2005-11-18 10:06 UTC, Josef Zlomek 		rejected Details | Review

Description Josef Zlomek 2005-11-18 10:04:42 UTC 
The attached patch makes MPEG packetize to detect invalid data in the MPEG
stream (in most cases) and skip it.

It finds out the length of the current chjunk in the MPEG stream. Then it finds
out whether there is a start code after the current chunk. If there is not the
start chunk, some data in the stream are probably missing, i.e. the current
chunk is cut. So packetize skips one byte of current chunk and looks for the
next start code. Therefore it effectively skips the cur current chunk.

This improves stability when the source of MPEG stream is UDP, but not
completely, unfortunatelly.
Comment 1 Josef Zlomek 2005-11-18 10:06:23 UTC 
Created attachment 54908 [details] [review]
Patch to skip incorrect data
Comment 2 Tim-Philipp Müller 2006-01-19 15:24:43 UTC 
CC'ing Martin Soto
Comment 3 Christian Fredrik Kalager Schaller 2006-04-13 09:13:55 UTC 
Martin could you please take a look at this patch?
Comment 4 Edward Hervey 2009-03-06 09:12:24 UTC 
Is this bug still valid now that we have the new mpegpsdemux in -bad ?
Comment 5 Sebastian Dröge (slomo) 2009-09-09 17:19:29 UTC 
Closing because it's not really useful anymore because the prefered demuxers are the new ones from -bad now.