After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 321648 - Wrong type check in gst_message_parse_clock_lost
Wrong type check in gst_message_parse_clock_lost
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
git master
Other Linux
: Normal normal
: 0.9.6
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2005-11-16 19:55 UTC by Torsten Schoenfeld
Modified: 2005-11-17 09:38 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
NEW_CLOCK -> CLOCK_LOST (717 bytes, patch)
2005-11-16 19:55 UTC, Torsten Schoenfeld 		committed Details | Review

Description Torsten Schoenfeld 2005-11-16 19:55:29 UTC 
gst_message_parse_clock_lost incorrectly checks for messages of type
GST_MESSAGE_NEW_CLOCK instead of GST_MESSAGE_CLOCK_LOST.  Patch attached.
Comment 1 Torsten Schoenfeld 2005-11-16 19:55:59 UTC 
Created attachment 54837 [details] [review]
NEW_CLOCK -> CLOCK_LOST
Comment 2 Tim-Philipp Müller 2005-11-17 09:38:27 UTC 
Applied, thanks!

2005-11-17  Torsten Schoenfeld  <kaffeetisch at gmx dot net>

        * gst/gstmessage.c: (gst_message_parse_clock_lost):
          Assertion should check for CLOCK_LOST, not NEW_CLOCK (#321648).

        * gst/gstpadtemplate.h:
        * gst/gstpluginfeature.h:
          Don't use c++ style comments in headers (#321638).