After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 321596 - Importing should give the option to move the files
Importing should give the option to move the files
Status: RESOLVED FIXED
Product: f-spot
Classification: Other
Component: General
CVS
Other All
: Normal enhancement
: 0.7.2
Assigned To: F-spot maintainers
F-spot maintainers
: 343553 346370 353973 385880 510947 520095 540904 566939 603254 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2005-11-16 12:46 UTC by Carsten Schurig
Modified: 2010-08-26 11:54 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
proposed patch (6.41 KB, patch)
2006-08-29 20:37 UTC, Gautier Portet
needs-work Details | Review
First try of deleting files when importing from camera, still without checkbox for optional deleting. (1.19 KB, patch)
2007-01-31 21:17 UTC, Artur Flinta
needs-work Details | Review
Full patch which adds support for optional removing photos from camera during import (3.18 KB, patch)
2007-02-01 21:05 UTC, Artur Flinta
needs-work Details | Review
UI + code to allow deleting pictures after download (2.57 KB, patch)
2008-01-08 17:35 UTC, Roland Mas
none Details | Review
Updated, with ChangeLog (3.19 KB, patch)
2008-01-08 17:40 UTC, Roland Mas
none Details | Review
Updated to follow coding style guidelines (3.13 KB, patch)
2008-01-12 16:56 UTC, Roland Mas
none Details | Review
Only delete files after import (3.43 KB, patch)
2008-01-26 23:07 UTC, Roland Mas
needs-work Details | Review

Description Carsten Schurig 2005-11-16 12:46:41 UTC
Currently on import f-spot just gives an option to copy the pictures. So
currently I need an additional application to delete the "originals". This is
esp. annoying if I import directly from the camera, as I either have to use
another special application (Canon's just provide PTP and no USB mass storage
mode) or need to use the camera menu itself. Also if I using card reader I want
to delete the images from the card on import.

Maybe f-spot could ask after it copied the images to the Photos folder, if the
originals should be removed.

Other information:
Comment 1 Bengt Thuree 2005-11-19 06:05:05 UTC
In addition to this, perhaps F-Spot could do a MD5 sum of the original and the
just copied photo, to ensure that the photo has been correctly copied before
erasing it from the original source.
Or this should be part of the import process?

Anyway, letting F-Spot automatically erase the original photo without confirming
that the copy was successfull is not something I would like to take a chance on
Comment 2 Carsten Schurig 2005-11-19 09:42:18 UTC
Yes, verifying that the copy was successful ist definetly desirable.
Comment 3 Larry Ewing 2006-01-09 05:07:22 UTC
most camera manuals I've seen explicitly say to delete the photos from the camrea using the camera not using the computer.  I'm not sure if there is an actual issue there or not.  It is probably worth chacking with the gphoto developers.
Comment 4 Jean-François Fortin Tam 2006-03-09 22:49:45 UTC
Well, from my (limited) experience with casual users (those who point and shoot), they expected the cameras to be "on the computer". That's what importing is about, otherwise, it's called cloning... I love the idea of doing a fail check on top of that though. But still, maybe some people "want" to keep the pictures on that camera, and we cannot really neglect those, so I'm voting for a checkbox.
Comment 5 Jean-François Fortin Tam 2006-03-09 23:03:03 UTC
line 2:
they expected the *photos* to be "on the computer".

Sorry, my brain is messed up :)
Comment 6 Artur Flinta 2006-05-24 12:28:52 UTC
Well, any chance to get this checkbox on import dialog? F-spot is great, but when importing photos, gthumb is much better (cause it removes if required imported photos from camera - it's also using libgphoto2).
Comment 7 Elijah Newren 2006-06-01 03:31:59 UTC
*** Bug 343553 has been marked as a duplicate of this bug. ***
Comment 8 Hubert Figuiere (:hub) 2006-06-30 19:19:57 UTC
(In reply to comment #3)
> most camera manuals I've seen explicitly say to delete the photos from the
> camrea using the camera not using the computer.  I'm not sure if there is an
> actual issue there or not.  It is probably worth chacking with the gphoto
> developers.
> 

Some camera do not support delete. Sony cams in PTP for example.

BTW move can be implemented as download - delete. The safe implementation would download everything and delete what has been safely downloaded.
Comment 9 Ania Tarchalska 2006-07-02 10:54:57 UTC
Most of the p&s cameras owners I know refuse to use f-spot on their linux boxes and windows users just laugh, after finding out, that they have to manually delete imported photos from the camera level.

They mostly say "Hey, what kind of program it is, it forces me to use the camera to manage my photos!"

Comment 10 Ania Tarchalska 2006-07-20 22:47:49 UTC
Maybe, until things don't clear up (Comment #3 from Larry Ewing), it is possible to introduce an option to delete the pics from the camera after importing is completed, in the gconf-editor?
Comment 11 Gautier Portet 2006-08-29 20:37:53 UTC
Created attachment 71862 [details] [review]
proposed patch

This bug is really annoying, here is a small fix to get the job done.
Comment 12 Karl Palsson 2006-09-13 03:00:51 UTC
I guess I'm just a freak who thinks it's nothing to do with the photo management software to get the photos off the camera.

Regardless, when you stick the card back into your camera, just press format.  It'll save you from any woes of corrupted memory cards down the road too, and means you don't care whether you're photo downloader/manager copied, moved or whatever.

Comment 13 Stephane Delcroix 2006-09-13 08:10:40 UTC
*** Bug 353973 has been marked as a duplicate of this bug. ***
Comment 14 Ania Tarchalska 2006-09-13 11:35:01 UTC
> I guess I'm just a freak who thinks it's nothing to do with the photo
> management software to get the photos off the camera.

You're right, that kind of statement is rather weird.
Get the pictures, clean the card, PP, print -- this is a simply, natural way for the Joe Sixpack.

OK, sorry, that is your way, but not everyone can follow, please read on

> Regardless, when you stick the card back into your camera, just press format.

I never get the card out of the camera (really) nor most of my friends do,
USB is my friend.

Moreover many digicam owners I know do not speak English, so telling them to go to the 'Menu', find 'Playback Menu', then select 'Delete' and then press 'Format Card'
is like talking in Sanskrit.



It is not 'All ya have to do this' feature,
it's an option for the people who badly need this.
Comment 15 Michael Monreal 2006-09-13 14:53:01 UTC
If I can add my 2 cent: my "cam" is my mobile phone. It has a nice cam so I use it often to just make a few photos wherever I go, get home and download them to the pc. Sure I could delete the pictures on the phone after that but I would have to delete them on by one because there is no "clear card" option (and I wouldn't want to clear the card, just delete the photos I have on the pc now...)

Right now I always use nautilus to delete those photos but it would be really helpful to have just this option "delete after successful import"
Comment 16 Pavel Šefránek 2006-09-13 15:07:31 UTC
I strongly agree with Michael. We all want desktop that just works.
And finding where is the fucking option to format a memcard (especially our grandmothers or normal users don't want to do that) is not the right way where we should go. Of course, there will be still an option for geeks to not tick the checkbox.
Comment 17 Hubert Figuiere (:hub) 2006-09-13 15:13:11 UTC
(In reply to comment #15)
> If I can add my 2 cent: my "cam" is my mobile phone. 

And it is supported by libgphoto2?
Comment 18 Artur Flinta 2006-09-13 15:30:49 UTC
Who cares? It's just works in gthumb which is using libgphoto2, it's not software for Atomic powerplant.
Comment 19 Michael Monreal 2006-09-13 15:57:36 UTC
@Hubert:

It's usb mass storage. I don't know if f-spot uses gphoto2 to access that, all I know is that if I plug in my thone I get a nice dialog asking me if I want to import my photos (if there are any) from the phone. As I don't want them to be archived I say yes and f-spot starts and gives me the import options. I import. Until then this is a *perfect* workflow, a dream come true. But now I have to navigate to the pics folder on the cam using nautilus and delete the photos my hand. And because I don't want them to be moved to .Trash on the phone, I also have to empty the trash. Would be so much easier if f-spot just had an option for this...
Comment 20 Hubert Figuiere (:hub) 2006-09-13 16:36:15 UTC
(In reply to comment #19)
> @Hubert:
> 
> It's usb mass storage. 
Which phone is it?

Can I get the USB IDs? (for completeness)
Comment 21 Michael Monreal 2006-09-13 16:55:12 UTC
It's a Sony Ericsson K750i (Vendor=0xfce / Device=0xd016).
I also use an older Tevion cam sometimes... same there, if 
I connect it to the PC I want to get the photos archived 
and the card cleaned...
Comment 22 Gabriel Burt 2006-10-18 23:56:33 UTC
*** Bug 346370 has been marked as a duplicate of this bug. ***
Comment 23 Artur Flinta 2006-10-24 21:20:20 UTC
The 1st birthday of this bug is coming and still unresolved.
It is very annoying to manually remove few hundreds of photos by hand in camera after import, if I have to leave some pictures on memory card for later use.
Comment 24 Stephane Delcroix 2006-12-14 15:54:22 UTC
*** Bug 385880 has been marked as a duplicate of this bug. ***
Comment 25 Andreas Schildbach 2006-12-16 16:59:01 UTC
I'd really like to install f-spot for my mother. Unfortunately, f-spot's inability to move (rather than copy) photos on import is a blocker. My mother does not understand how to open a file browser, navigate to some subdirectory (she does not even know what a directory or a hierarchical structure is) and delete some pictures (but not the movies that f-spot can't handle anyway).

So pretty please, this is really a no-brainer. If you want f-spot to replace gthumb and the like, there is no way around this enhancement.
Comment 26 Artur Flinta 2007-01-28 20:36:50 UTC
I've been playing for some time with gphoto2 and it works perfectly with downloading and _deleting_ files from camera, I don't know why it take so long to implement this _basic_ feature.
Comment 27 Hubert Figuiere (:hub) 2007-01-30 20:08:25 UTC
(In reply to comment #26)
> I've been playing for some time with gphoto2 and it works perfectly with
> downloading and _deleting_ files from camera, I don't know why it take so long
> to implement this _basic_ feature.
> 

Since it basic, we are waiting for your patch :-)
Comment 28 Jean-François Fortin Tam 2007-01-30 20:16:00 UTC
I'm sure it is basic from a *user* perspective :). But hey, didn't comment #11 contain a patch already?
Comment 29 Artur Flinta 2007-01-30 20:52:31 UTC
Well, it's not so easy for me to spend a time for learning another programming language and libgphoto2 API :)

Patch from comment #11 seems not to work and if I remember, checkbox for deleting messages is in main window instead of import dialog. Maybe this is working when importing from another folder, but not from camera.
Comment 30 Artur Flinta 2007-01-31 21:16:05 UTC
Ok, I've prepared first path which is working for me. I've tried also add checkbox to import dialog via glade-2 tool, but after regeneration of glade file I have problem with f-spot crash during startup, maybe it need some other changes, but I think it's good point to start.

Regards
Artur 
Comment 31 Artur Flinta 2007-01-31 21:17:16 UTC
Created attachment 81629 [details] [review]
First try of deleting files when importing from camera, still without checkbox for optional deleting.
Comment 32 Stephane Delcroix 2007-02-01 08:29:12 UTC
Artur,

here's the trick to avoid the glade issue.

- get a fresh f-spot.glade from svn
- open with glade-2, don't do anything, save the file
- svn diff f-spot.glade > glade.diff
- open f-spot.glade with glade-2, do your modifications, save
- patch -p0 -R < glade.diff
- compile and run
Comment 33 Artur Flinta 2007-02-01 21:03:32 UTC
Thx for tips, now it's working for me, maybe it's also working for You :)
Attached complete patch.

Regards
   Artur
Comment 34 Artur Flinta 2007-02-01 21:05:07 UTC
Created attachment 81704 [details] [review]
Full patch which adds support for optional removing photos from camera during import
Comment 35 Artur Flinta 2007-02-16 13:39:49 UTC
OK, did any one test this patch in own environment?
Comment 36 Sascha Umlang 2007-02-21 21:12:31 UTC
Just tested it against latest HEAD. Works fine.
Comment 37 Łukasz Jernaś 2007-08-13 16:11:47 UTC
Artur could you take a look at your patch? It doesn't apply on current HEAD and 0.4.0
Comment 38 Artur Flinta 2007-08-14 07:47:33 UTC
I've changed my camera to DSLR and this patch is not usable for me anymore (my Pentax is now visible as mass storage device) so I'm unable to test it as before. Sorry.
Comment 39 Jean-François Fortin Tam 2007-08-14 14:09:07 UTC
Nah, as far as I know, you can still test it by selecting the folder of the usb mass storage. All my cameras are USB mass storage and I could import photos with f-spot's dialog. Give it a shot!
Comment 40 Artur Flinta 2007-08-14 14:41:51 UTC
If I remember correctly, this fix was working only with PTP cameras, not a mass storage (it wasn't implemented).
Comment 41 Jean-François Fortin Tam 2007-08-14 15:02:02 UTC
well couldn't this be adapted slightly so that it does rm on the files? (I don't know if this is the correct way to do it)
Comment 42 Artur Flinta 2007-08-14 15:08:25 UTC
Unfortunately I don't have time to maintain this patch, moreover I'm making photos only in RAW, so before importing them to F-Spot I have to do some processing using Rawtherapee (F-Spot lacks many RAW processing features), so import from camera is not important for me :)
I'll look at it at home, but I can't guarantee that it will be working.
Comment 43 Matthew Gregg 2007-12-20 04:02:54 UTC
Any hope of this every being resolved?  I've been looking at f-spot again since it added the ability to set the base and photo directory, but this bug is still the show stopper.
Comment 44 Roland Mas 2008-01-08 17:35:34 UTC
Created attachment 102404 [details] [review]
UI + code to allow deleting pictures after download

Updated patch, applicable to current SVN trunk.
Comment 45 Roland Mas 2008-01-08 17:40:22 UTC
Created attachment 102405 [details] [review]
Updated, with ChangeLog

Now with a proper ChangeLog entry documenting the changes
Comment 46 Roland Mas 2008-01-12 16:56:35 UTC
Created attachment 102667 [details] [review]
Updated to follow coding style guidelines
Comment 47 Maxxer 2008-01-21 07:13:32 UTC
*** Bug 510947 has been marked as a duplicate of this bug. ***
Comment 48 Rob Frohne 2008-01-23 03:47:29 UTC
The patch doesn't seem to work with Mass Storage Devices for me anyway.  I would like this functionality.  The patch seemed to work ok and the build went well on the head of svn, but I don't see any buttons to check if I want to delete the photos on the camera.  Perhaps it is because the camera I tested behaves as a Mass Storage Device.  Or did I miss something?

Thanks for any help!

Rob
Comment 49 Rob Frohne 2008-01-23 21:20:45 UTC
Further report on the patch:

It works fine with a PTP camera.  

Rob
Comment 50 Maxxer 2008-01-23 22:52:28 UTC
Sad news: pressing "Cancel" at half of the import causes the images to get lost, as they're not imported into f-spot BUT already deleted from the camera!


To be honest, the pictures are saved into f-spot photodir, but not imported in f-spot. But this is another issue (bug 511666)...
That causes also a locking of the camera, but that's another issue (bug 511663)...
Comment 51 Roland Mas 2008-01-26 23:07:08 UTC
Created attachment 103791 [details] [review]
Only delete files after import

This version of the patch only deletes pics from the camera after they've been imported.
Comment 52 g11024342@trbvm.com 2008-02-06 22:01:29 UTC
Nice feature! I've been waiting for this...
Comment 53 Maxxer 2008-03-03 13:53:44 UTC
*** Bug 520095 has been marked as a duplicate of this bug. ***
Comment 54 Maxxer 2008-06-30 11:59:01 UTC
*** Bug 540904 has been marked as a duplicate of this bug. ***
Comment 55 Simon 2008-10-07 11:42:48 UTC
Looking forward to seeing this implemented in f-spot in Ubuntu.
Comment 56 Pavel Šefránek 2008-10-07 12:44:14 UTC
Dont worry. We, CCers are all looking forward to see this implemented (and not only in Ubuntu).
Comment 57 Maxxer 2009-01-07 19:49:50 UTC
*** Bug 566939 has been marked as a duplicate of this bug. ***
Comment 58 Christian Stöveken 2009-05-20 11:30:55 UTC
Still not implemented in f-spot 0.5.0.3 (at least for importing from folder / card reader).

Will it see it's 4th anniversary?
Comment 59 Maxxer 2009-11-29 13:19:49 UTC
*** Bug 603254 has been marked as a duplicate of this bug. ***
Comment 60 Jeremy Nickurak 2010-05-18 23:06:09 UTC
Just hit this one myself. Quite annoying. When I plug in my camera and load up f-spot, it's because my camera is full and i want to make room for more! Consequently, I really want to be able to easilly delete everything I import. It's equally important that when it's plugged in, and I only choose a few things to import, that the rest don't dissapear. That's a risk when we're asked to import and then delete in two seperate actions: I can forget what I've imported, and what's still only on the camera, and therefore end up losing data.
Comment 61 Matthew Gregg 2010-05-19 00:32:25 UTC
Nearly 5 years and we still can't move images.  It's important enough to some to do the work and submit a patch.  I understand it's a hard problem, not wanting to delete images that haven't been moved, but this is one of the most annoying parts of my f-spot work-flow.  Please consider getting this done.
Comment 62 Ruben Vermeersch 2010-06-24 14:43:12 UTC
Comment on attachment 71862 [details] [review]
proposed patch

Maintenance update: In the past we've been less than stellar in reviewing patches. As such we have a pile of patches in bugzilla which are outdated and don't apply anymore. Am currently marking all of these as "needs-work". My apologies for this.

Since I've become a maintainer of the project, I've set the personal rule of quickly reviewing all patches, to avoid that this happens again. If you (or anyone) wants to go through the trouble of updating this patch, please talk to us to figure out if it fits in the F-Spot long term roadmap.

Should you, in the future, notice a patch lingering around for too long, please notify us immediately and we'll look into it, to avoid situations like these from happening again.

You can filter these mails by searching for ###F-OLDPATCHCLEANUP###
Comment 63 Ruben Vermeersch 2010-06-24 14:43:15 UTC
Comment on attachment 81629 [details] [review]
First try of deleting files when importing from camera, still without checkbox for optional deleting.

Maintenance update: In the past we've been less than stellar in reviewing patches. As such we have a pile of patches in bugzilla which are outdated and don't apply anymore. Am currently marking all of these as "needs-work". My apologies for this.

Since I've become a maintainer of the project, I've set the personal rule of quickly reviewing all patches, to avoid that this happens again. If you (or anyone) wants to go through the trouble of updating this patch, please talk to us to figure out if it fits in the F-Spot long term roadmap.

Should you, in the future, notice a patch lingering around for too long, please notify us immediately and we'll look into it, to avoid situations like these from happening again.

You can filter these mails by searching for ###F-OLDPATCHCLEANUP###
Comment 64 Ruben Vermeersch 2010-06-24 14:43:19 UTC
Comment on attachment 81704 [details] [review]
Full patch which adds support for optional removing photos from camera during import

Maintenance update: In the past we've been less than stellar in reviewing patches. As such we have a pile of patches in bugzilla which are outdated and don't apply anymore. Am currently marking all of these as "needs-work". My apologies for this.

Since I've become a maintainer of the project, I've set the personal rule of quickly reviewing all patches, to avoid that this happens again. If you (or anyone) wants to go through the trouble of updating this patch, please talk to us to figure out if it fits in the F-Spot long term roadmap.

Should you, in the future, notice a patch lingering around for too long, please notify us immediately and we'll look into it, to avoid situations like these from happening again.

You can filter these mails by searching for ###F-OLDPATCHCLEANUP###
Comment 65 Ruben Vermeersch 2010-06-24 14:43:22 UTC
Comment on attachment 103791 [details] [review]
Only delete files after import

Maintenance update: In the past we've been less than stellar in reviewing patches. As such we have a pile of patches in bugzilla which are outdated and don't apply anymore. Am currently marking all of these as "needs-work". My apologies for this.

Since I've become a maintainer of the project, I've set the personal rule of quickly reviewing all patches, to avoid that this happens again. If you (or anyone) wants to go through the trouble of updating this patch, please talk to us to figure out if it fits in the F-Spot long term roadmap.

Should you, in the future, notice a patch lingering around for too long, please notify us immediately and we'll look into it, to avoid situations like these from happening again.

You can filter these mails by searching for ###F-OLDPATCHCLEANUP###
Comment 66 Maxxer 2010-08-26 11:54:14 UTC
this was implemented in f-spot 0.7.2