After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 321241 - faad compile fix
faad compile fix
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal normal
: 0.9.5
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2005-11-11 17:01 UTC by j^
Modified: 2005-11-11 18:21 UTC
See Also:
GNOME target: ---
GNOME version: 2.11/2.12

Attachments
the patch (738 bytes, patch)
2005-11-11 17:02 UTC, j^ 		none Details | Review

Description j^ 2005-11-11 17:01:51 UTC 
Distribution/Version: Ubuntu/Breezy

gst-plugins-bad fails to compile here because 
samplerate is gulong samplerate and faacDecInit/faacDecInit2
expects a pointer to an int, attached patch replaces
gulong with guint, that way it compiles fine here.
Comment 1 j^ 2005-11-11 17:02:46 UTC 
Created attachment 54646 [details] [review]
the patch
Comment 2 Michael Smith 2005-11-11 18:21:20 UTC 
Much nastier, more invasive, ugly fix committed.

FAAD upstream (which some systems have) has a broken header file. Most
distributions patch it. 

So, committed evilness to avoid definition of these functions, and instead
define them locally. Then call with correct API.