Bug 321240 – [PLUGIN-MOVE] dfbvideosink should be moved to -good

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 321240 - [PLUGIN-MOVE] dfbvideosink should be moved to -good


Summary:	[PLUGIN-MOVE] dfbvideosink should be moved to -good


Status:	RESOLVED INCOMPLETE

Product:	GStreamer
Classification:	Platform
Component:	gst-plugins-bad
Version:	git master
Hardware:	Other Linux

Importance:	Normal enhancement
Target Milestone:	git master
Assigned To:	GStreamer Maintainers
QA Contact:	GStreamer Maintainers

URL:
Whiteboard:

Depends on:	503743
Blocks:

Reported:	2005-11-11 16:14 UTC by Julien MOUTTE
Modified:	2013-08-22 13:03 UTC

See Also:
GNOME target:	---
GNOME version:	---

Attachments
Debug log (2.46 KB, text/plain) 2006-07-31 16:13 UTC, Wim Taymans	Details

Description Julien MOUTTE 2005-11-11 16:14:45 UTC

it has documentation, examples, it has all things a video sink could implement
and it's so neat !

Comment 1 Wim Taymans 2006-02-16 17:40:58 UTC

yes!

Comment 2 Jan Schmidt 2006-07-21 03:37:23 UTC

Do it! Do it!

Comment 3 Wim Taymans 2006-07-31 15:40:20 UTC

Maybe fix this first:

wim@wtay:~/gst/head/gstreamer$ gst-launch videotestsrc ! dfbvideosink
Setting pipeline to PAUSED ...

       ---------------------- DirectFB v0.9.24 ---------------------
             (c) 2000-2002  convergence integrated media GmbH
             (c) 2002-2004  convergence GmbH
        -----------------------------------------------------------

(*) DirectFB/Core: Single Application Core. (2006-06-14 07:02)
(*) Direct/Memcpy: Using MMXEXT optimized memcpy()
(!) DirectFB/core/vt: Error opening `/dev/tty0'!
    --> Permission denied
(!) DirectFB/Core: Could not initialize 'system' core!
    --> Initialization error!
Pipeline is PREROLLING ...
(!) [ 8212:    0.000] --> Caught signal 11 (at 0x14, invalid address) <--
Killed
wim@wtay:~/gst/head/gstreamer$

Comment 4 Wim Taymans 2006-07-31 16:08:45 UTC

Somehow it starts streaming and then fails in buffer_alloc.


Program received signal SIGSEGV, Segmentation fault.

+ Trace 69833

Thread NaN (LWP 9176)

#0 gst_dfbvideosink_buffer_alloc
at dfbvideosink.c line 1726
#1 gst_base_sink_pad_buffer_alloc
at gstbasesink.c line 404
#2 gst_pad_alloc_buffer_full
at gstpad.c line 2562
#3 gst_video_test_src_create
at gstvideotestsrc.c line 519
#4 gst_push_src_create
at gstpushsrc.c line 117
#5 gst_base_src_get_range
at gstbasesrc.c line 1304
#6 gst_base_src_loop
at gstbasesrc.c line 1473
#7 gst_task_func
at gsttask.c line 193
#8 g_thread_pool_push
from /usr/lib/libglib-2.0.so.0
#9 g_thread_create_full
from /usr/lib/libglib-2.0.so.0
#10 start_thread
from /lib/tls/libpthread.so.0
#11 clone
from /lib/tls/libc.so.6

Comment 5 Wim Taymans 2006-07-31 16:13:10 UTC

Created attachment 69984 [details]
Debug log

output of gst-launch-0.10 --gst-debug=dfbvideosink:5 videotestsrc ! dfbvideosink >/tmp/trace.log 2>&1

Comment 6 Wim Taymans 2006-07-31 17:32:45 UTC

the two commits make me happy again:

        * ext/directfb/dfbvideosink.c: (gst_dfbvideosink_change_state),
        (gst_dfbvideosink_buffer_alloc): Don't try allocating if we are not
        setup yet. Fail changing state if setup fails.

        * ext/directfb/dfbvideosink.c: (gst_dfbvideosink_change_state),
        (gst_dfbvideosink_buffer_alloc): Post an error message.

Comment 7 Sebastian Dröge (slomo) 2007-09-21 06:59:17 UTC

Ok, so what's missing now to get this moved other than someone doing the move? :)

Comment 8 Sebastian Dröge (slomo) 2007-11-11 14:02:11 UTC

Well, it looks OK from my side... marking as a blocker for the coming releases.

Comment 9 Sebastian Dröge (slomo) 2008-01-23 10:53:46 UTC

bug #503743 should be done before I guess... as it might need API changes. Unmarking this bug as blocker until this is done and we have a second review.

Comment 10 Tim-Philipp Müller 2008-02-23 10:37:33 UTC

The cause of bug #517854 should also be investigated and fixed before a move.

Comment 11 Christian Fredrik Kalager Schaller 2011-05-20 13:55:17 UTC

Is this plugin ready to be moved now?

Comment 12 Julien MOUTTE 2011-05-20 14:02:12 UTC

Hey Christian :)

I haven't checked it in a long long time. I assume it's not as good as it used to be compared to today's GStreamer standards. It would need some QA/polish before that happens IMHO.

Cheers,

Comment 13 Sebastian Dröge (slomo) 2013-08-22 12:32:12 UTC

Anybody planning to work on this? Does it make sense to keep this bug open for now?

Comment 14 Tim-Philipp Müller 2013-08-22 12:39:50 UTC

Needs porting first (see bug #321240).

I would suggest we close this bug until someone expresses some interest again and willingness to work on it to achieve the move.