After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 321136 - [matroska-mux] avoid reading from unref'ed buffer
[matroska-mux] avoid reading from unref'ed buffer
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Linux
: Normal normal
: 0.9.5
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2005-11-10 10:05 UTC by Josef Zlomek
Modified: 2005-11-10 12:23 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Read duration before pushing buffer (1.47 KB, patch)
2005-11-10 10:06 UTC, Josef Zlomek 		committed Details | Review

Description Josef Zlomek 2005-11-10 10:05:34 UTC 
When matroska muxer is going to write the block duration, it reads the duration
from buffer which has been already passed to gst_pad_push and thus possibly
unreferenced.

The attached patch assigns the duration to a variable before pushing it to pad.
Comment 1 Josef Zlomek 2005-11-10 10:06:11 UTC 
Created attachment 54569 [details] [review]
Read duration before pushing buffer
Comment 2 Tim-Philipp Müller 2005-11-10 12:23:11 UTC 
Thanks, committed to CVS:

2005-11-10  Josef Zlomek  <josef dot zlomek at xeris dot cz>

       * gst/matroska/matroska-mux.c: (gst_matroska_mux_write_data):
         Don't try to ready buffer duration from buffer that we don't
         own any  longer and that might already have been unreffed.
         (#321136)

Cheers
 -Tim