After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 321011 - gstbasertpdepayload doesn't send the "new segment" event for all instances
gstbasertpdepayload doesn't send the "new segment" event for all instances
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Linux
: Normal major
: 0.9.5
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2005-11-08 21:43 UTC by Sebastien Cote
Modified: 2005-11-08 22:34 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Proposed fix (1.96 KB, patch)
2005-11-08 21:50 UTC, Sebastien Cote 		reviewed Details | Review

Description Sebastien Cote 2005-11-08 21:43:23 UTC 
The base depayloader class (gstbasertpdepayload) sends the "new segment" event
only the first time it is run.

This is because gst_base_rtp_depayload_set_gst_timestamp() is using a static
(eek!!!) variable to indicate the first frame.
Comment 1 Sebastien Cote 2005-11-08 21:50:33 UTC 
Created attachment 54503 [details] [review]
Proposed fix

Adds a variable to the class to indicate the first frame.
Comment 2 Tim-Philipp Müller 2005-11-08 22:34:19 UTC 
Thanks, applied with modifications (use 'need_newsegment' instead of 'first' and
maintain API and ABI compatibility. gstbasertpdepayload.h is a publicly
installed header after all):

 2005-11-08  Sebastien Cote  <sebas642 at yahoo dot ca>

        * gst-libs/gst/rtp/gstbasertpdepayload.c:
        (gst_base_rtp_depayload_init),
        (gst_base_rtp_depayload_set_gst_timestamp):
        * gst-libs/gst/rtp/gstbasertpdepayload.h:
          We need to send a newsegment event for each instance, not
          just for the first instance of this class (get rid of
          static variable in function). (#321011).

Cheers
 -Tim