After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 320947 - Create Web Album Tool doesn't generate HTML pages with International characters
Create Web Album Tool doesn't generate HTML pages with International characters
Status: RESOLVED FIXED
Product: gthumb
Classification: Other
Component: general
2.6.x
Other All
: Normal normal
: ---
Assigned To: Paolo Bacchilega
Paolo Bacchilega
Depends on:
Blocks:
 
 
Reported: 2005-11-08 10:29 UTC by danieyek
Modified: 2005-11-13 08:58 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description danieyek 2005-11-08 10:29:37 UTC
Please describe the problem:
Image file names containing International characters (eg. 万星号) are shown as
follow (example) in the web page generated (in the image file name displayed):

%E4%B8%87%E6%98%9F%E5%8F%B7

Rather than a properly formated HTML page that displays native characters in
file names.

This properly means that the Create Web Album tool doesn't have International
support yet and it would be nice to support it.



Steps to reproduce:
1. Rename a jpeg file to 万星号.jpeg
2. Select this jpeg file
3. Use the Web Album Tool to generate a web album, making sure that the image
file name is inserted into the web page.
4. Check if the file name is shown as 万星号.jpeg or
%E4%B8%87%E6%98%9F%E5%8F%B7.jpeg.


Actual results:
The web page shows %E4%B8%87%E6%98%9F%E5%8F%B7.jpeg as the file name.

Expected results:
The web page should shows 万星号.jpeg

Does this happen every time?
Yes

Other information:
Comment 1 danieyek 2005-11-09 13:31:31 UTC
I'm able to disable the encoding of file names by modifying the source code as
follow:

gthumb-2.6.5/src/catalog-web-exporter.c:
static void
gth_parsed_doc_print (GList              *document,
		      CatalogWebExporter *ce,
		      FILE               *fout,
		      gboolean            allow_table)
{
  //...
  case GTH_TAG_IMAGE:
    // ...
    //escaped_path = escape_uri (image_src_relative);
    //e_escaped_path = _g_escape_text_for_html (escaped_path, -1);
    e_escaped_path = _g_escape_text_for_html (image_src_relative, -1);

    //...
    //g_free (escaped_path);
    //...

  case GTH_TAG_FILENAME:
    // ...
    if  (gth_tag_get_var (ce, tag, "utf8") != 0) 
      write_markup_escape_locale_line (line, fout);
    else {
      //escaped_path = escape_uri (line);
      //g_free (line);
      //line = escaped_path;
      write_markup_escape_line (line, fout);
    }
    // ...
}

This provides the "fix" that I need. However, I think it would be better to
encode the HREF URLs in the Web Album html pages but not the file names
displayed as information for the user. I don't have a fix for this yet.

Could this bug be fixed in the future release?

Thanks.
Comment 2 Paolo Bacchilega 2005-11-13 08:58:50 UTC
Fixed in current CVS, both HEAD and gthumb-2-6 branches.