GNOME Bugzilla – Bug 320923
[volume] doesn't build on Solaris
Last modified: 2005-11-08 09:03:08 UTC
in gst-plugins-base 0.9.4, gst/volume/gstvolume.c won't build on Solaris with the Forte compiler with the following error: "gstvolume.c", line 396: syntax error before or at: 0 I suspect this problem is caused because the GST_ELEMENT_ERROR macro is improperly defined. Attaching a patch that seems to correct this problem.
Created attachment 54443 [details] [review] patch to fix the macro to compile on Solaris with Forte
Could you check whether this works as well (ie. just putting the final NULL in brackets): if (!this->process) { - GST_ELEMENT_ERROR (this, CORE, NEGOTIATION, - ("Invalid incoming caps: %" GST_PTR_FORMAT, incaps), NULL); + GST_ELEMENT_ERROR (this, CORE, NEGOTIATION, + ("Invalid incoming caps: %" GST_PTR_FORMAT, incaps), (NULL)); return FALSE; } return TRUE; Cheers -Tim
Yes, that also compiles okay.
Thanks for confirming, applied the latter to CVS HEAD (the first chunk is the user-visible error message, the second one is an optional debug message that is meant to contain further technical details and shouldn't be visible to the user; if you move the (NULL) to the front there won't be a user-visible error, which isn't quite what we want). 2005-11-08 Brian Cameron <brian dot cameron at sun dot com> * gst/volume/gstvolume.c: (volume_set_caps): Fix compilation on Solaris with Forte. (#320923) Cheers -Tim