GNOME Bugzilla – Bug 320869
xfer fails silently
Last modified: 2005-11-08 12:07:38 UTC
among the others, try the following: gnomevfs-copy README ftp://ftp.gnome.org/robots.txt gnomevfs-copy /etc/fstab ssh://paolo:xxxx@localhost/foo.txt (where /foo.txt, already exists) ditto for http and others: these operations obviously fail because we don't have write permissions, but xfer returns success. This is a real major problem for gedit vfs support because means that we cannot reliably tell if a file was saved successfully ot not
Created attachment 54412 [details] [review] patch this patch fixes the issue for us... it's a quick patch, and the comment makes me wonder if there was a rationale behind the behavior. Or maybe the comment is just on crack... Another option is not to assing result = VFS_OK even when handle_error returns true, since we pass it a &result and thus it should set the result to the proper value on its own
I tried to track down the reason for the initial comment, but couldn't figure it out. The patch looks right to me, so I'm commiting it to HEAD. But i'm always wary about changes to gnome_vfs_xfer, so we should keep a lookout for problems caused by this change.