After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 320686 - Gtk-CRITICAL when clicking column header in history
Gtk-CRITICAL when clicking column header in history
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: History
1.9.x
Other Linux
: High critical
: 2.14.x
Assigned To: Epiphany Maintainers
Marco Pesenti Gritti
Depends on:
Blocks:
 
 
Reported: 2005-11-04 11:22 UTC by spark
Modified: 2006-01-17 19:41 UTC
See Also:
GNOME target: ---
GNOME version: 2.13/2.14


Description spark 2005-11-04 11:22:57 UTC 
Gtk-CRITICAL when clicking column header in history
Comment 1 Christian Persch 2005-11-04 11:27:40 UTC 



+
Trace
    63890






    

  • 
#0
trap_handler

    
                at ../../lib/ephy-debug.c
                  line
                  146

    

    • 

  • 
#1
IA__g_logv

    
                at gmessages.c
                  line
                  474

    

    • 

  • 
#2
IA__g_log

    
                at gmessages.c
                  line
                  517

    

    • 

  • 
#3
IA__g_return_if_fail_warning

    
                at gmessages.c
                  line
                  532

    

    • 

  • 
#4
gtk_tree_model_sort_set_sort_column_id

    
                at gtktreemodelsort.c
                  line
                  1373

    

    • 

  • 
#5
IA__gtk_tree_sortable_set_sort_column_id

    
                at gtktreesortable.c
                  line
                  147

    

    • 

  • 
#6
gtk_tree_view_column_sort

    
                at gtktreeviewcolumn.c
                  line
                  1188

    

    • 

  • 
#7
IA__g_cclosure_marshal_VOID__VOID

    
                at gmarshal.c
                  line
                  77

    

    • 

  • 
#8
IA__g_closure_invoke

    
                at gclosure.c
                  line
                  492

    

    • 

  • 
#9
signal_emit_unlocked_R

    
                at gsignal.c
                  line
                  2485

    

    • 

  • 
#10
IA__g_signal_emit_valist

    
                at gsignal.c
                  line
                  2244

    

    • 

  • 
#11
IA__g_signal_emit_by_name

    
                at gsignal.c
                  line
                  2312

    

    • 

  • 
#12
gtk_tree_view_column_button_clicked

    
                at gtktreeviewcolumn.c
                  line
                  1102

    

    • 

  • 
#13
IA__g_cclosure_marshal_VOID__VOID

    
                at gmarshal.c
                  line
                  77

    

    • 

  • 
#14
IA__g_closure_invoke

    
                at gclosure.c
                  line
                  492

    

    • 

  • 
#15
signal_emit_unlocked_R

    
                at gsignal.c
                  line
                  2485

    

    • 

  • 
#16
IA__g_signal_emit_valist

    
                at gsignal.c
                  line
                  2244

    

    • 

  • 
#17
IA__g_signal_emit

    
                at gsignal.c
                  line
                  2288

    

    • 

  • 
#18
IA__gtk_button_clicked

    
                at gtkbutton.c
                  line
                  834

    

    • 

  • 
#19
gtk_real_button_released

    
                at gtkbutton.c
                  line
                  1369

    

    • 

  • 
#20
IA__g_cclosure_marshal_VOID__VOID

    
                at gmarshal.c
                  line
                  77

    

    • 

  • 
#21
g_type_class_meta_marshal

    
                at gclosure.c
                  line
                  569

    

    • 

  • 
#22
IA__g_closure_invoke

    
                at gclosure.c
                  line
                  492

    

    • 

  • 
#23
signal_emit_unlocked_R

    
                at gsignal.c
                  line
                  2415

    

    • 

  • 
#24
IA__g_signal_emit_valist

    
                at gsignal.c
                  line
                  2244

    

    • 

  • 
#25
IA__g_signal_emit

    
                at gsignal.c
                  line
                  2288

    

    • 

  • 
#26
IA__gtk_button_released

    
                at gtkbutton.c
                  line
                  826

    

    • 

  • 
#27
gtk_button_button_release

    
                at gtkbutton.c
                  line
                  1262

    

    • 

  • 
#28
_gtk_marshal_BOOLEAN__BOXED

    
                at gtkmarshalers.c
                  line
                  83

    

    • 

  • 
#29
g_type_class_meta_marshal

    
                at gclosure.c
                  line
                  569

    

    • 

  • 
#30
IA__g_closure_invoke

    
                at gclosure.c
                  line
                  492

    

    • 

  • 
#31
signal_emit_unlocked_R

    
                at gsignal.c
                  line
                  2523

    

    • 

  • 
#32
IA__g_signal_emit_valist

    
                at gsignal.c
                  line
                  2254

    

    • 

  • 
#33
IA__g_signal_emit

    
                at gsignal.c
                  line
                  2288

    

    • 

  • 
#34
gtk_widget_event_internal

    
                at gtkwidget.c
                  line
                  3735

    

    • 

  • 
#35
IA__gtk_propagate_event

    
                at gtkmain.c
                  line
                  2169

    

    • 

  • 
#36
IA__gtk_main_do_event

    
                at gtkmain.c
                  line
                  1406

    

    • 

  • 
#37
gdk_event_dispatch

    
                at gdkevents-x11.c
                  line
                  2291

    

    • 

  • 
#38
IA__g_main_context_dispatch

    
                at gmain.c
                  line
                  1934

    

    • 

  • 
#39
g_main_context_iterate

    
                at gmain.c
                  line
                  2565

    

    • 

  • 
#40
IA__g_main_loop_run

    
                at gmain.c
                  line
                  2769

    

    • 

  • 
#41
IA__gtk_main

    
                at gtkmain.c
                  line
                  985

    

    • 

  • 
#42
main

    
                at ../../src/ephy-main.c
                  line
                  312

    

    • 













Comment 2


Crispin Flowerday (not receiving bugmail)





          2006-01-02 14:25:54 UTC
        



This bug is a bit evil, I have worked out why it is happening:

Using EphyNodeView there is a chain of models, which goes

 sortmodel -> filtermodel -> ephy_tree_model_node

When the sortmodel is constructed, it calls gtk_tree_model_get_n_columns on it's child model, however although ephy_tree_model_node has been told about the EphyNode to get it's data, it doesn't know how many columns it is going to contain, so it returns 0.

This means that the sortmodel doesn't know how the columns should be sorted, so it doesn't have entries in the 'sort_list' for them.

I can see 2 ways round this:

- Call gtk_tree_sortable_set_sort_func manually for the columns that need to be sorted
- Tell ephy_tree_model_node the columns and types that it will contain, so that get_n_columns  returns the correct thing.






Comment 3


Christian Persch





          2006-01-02 21:59:24 UTC
        



I think I slightly prefer the 2nd option, but I'm okay with whatever is less work, esp. considering we'd like to get rid of EphyNode* soon...






Comment 4


Reinout van Schouwen





          2006-01-16 00:39:03 UTC
        



This bug crashes Epiphany with the new glib version...






Comment 5


Crispin Flowerday (not receiving bugmail)





          2006-01-17 19:41:01 UTC
        



Fixed in CVS:

http://mail.gnome.org/archives/cvs-commits-list/2006-January/msg04792.html