GNOME Bugzilla – Bug 320432
wont build w/ -Werror on gentoo
Last modified: 2006-01-04 11:15:19 UTC
Distribution/Version: gentoo Linux aleph 2.6.14-rc5-mm1 #1 SMP PREEMPT Mon Oct 31 11:12:52 PST 2005 i686 Intel(R) Pentium(R) 4 CPU 3.20GHz GenuineIntel GNU/Linux http://pastebin.com/413644 rb-podcast-source.c: In function 'rb_podcast_source_post_date_cell_data_func': rb-podcast-source.c:1638: warning: `%x' yields only last 2 digits of year in some locales make[2]: *** [rb-podcast-source.lo] Error 1 make[2]: Leaving directory `/home/adamb/src/rhythmbox/sources' make[1]: *** [all-recursive] Error 1 make[1]: Leaving directory `/home/adamb/src/rhythmbox' make: *** [all] Error 2 removed -Werror from sources/Makefile to build
Created attachment 54207 [details] [review] patch The "%x" means "preferred date format for the current locale", which we use because we want the preffered format. gcc is spitting out the warning in case we are writing this out, which could cause y2k problems. The attached patch should turn off that warning, can you check to see if it helps?
Doesn't seem to work for me. I get the same old build error.
I tell a lie - it's the same error on a different line, although that's probably because I've just done a CVS checkout. Before: rb-podcast-source.c: In function `rb_podcast_source_post_date_cell_data_func': rb-podcast-source.c:1642: warning: `%x' yields only last 2 digits of year in some locales After: rb-podcast-source.c:1649: warning: `%x' yields only last 2 digits of year in some locales Anyway, looks like it's still a problem.
Created attachment 54270 [details] [review] disable format warnings I'd prefer not to disable format warnings, but we might have to. Can you try this patch?
I'm afraid that still doesn't work. I can't get RB to build successfully unless I turn off -Werror, which is probably not the right thing to do.
Created attachment 54403 [details] [review] really disable the warnings Either Gentoo or the version of gcc you are using must enable those warnings by default. This patch should force them to be disabled. If this doesn't work, I'm not sure how to fix it - because we really do want %x to do what it does, and it isn't a mistake that needs warning about.
Sorry, that still doesn't fix the problem. If I get time, I'll report it to the Gentoo devs.
Marking the patch rejected since it doesn't help
same error for ubuntu dapper.
For me the problem disappearred; Adam or Thomas could you confirm is it ok for you now ?
Yes, I think the problem has now gone away.
Closing so