After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 320362 - beagle-0.1.1 does not compile against latest wv-1.2.0
beagle-0.1.1 does not compile against latest wv-1.2.0
Status: RESOLVED FIXED
Product: beagle
Classification: Other
Component: General
0.1.x
Other Linux
: Normal major
: ---
Assigned To: Beagle Bugs
Beagle Bugs
Depends on:
Blocks:
 
 
Reported: 2005-11-01 01:34 UTC by Ed Catmur
Modified: 2005-11-03 21:55 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
support wv-1.2.0 (12.82 KB, patch)
2005-11-02 23:16 UTC, Daniel Drake
none Details | Review
support for wv-1.2.0 and wv-1.0.x (28.38 KB, patch)
2005-11-03 20:33 UTC, Veerapuram Varadhan
none Details | Review

Description Ed Catmur 2005-11-01 01:34:51 UTC
As acknowledged here:
http://mail.gnome.org/archives/dashboard-hackers/2005-October/msg00157.html

> Our glue code no longer compiles against 1.2.0. As they have switched to GSF, 
> the API has changed a lot.

Marking major because configure does not currently allow disabling the wv glue
code; if it finds the .pc it tries and fails to build the glue code. This means
to compile without wv it is necessary to patch configure.
Comment 1 Daniel Drake 2005-11-02 23:16:42 UTC
Created attachment 54252 [details] [review]
support wv-1.2.0

Here's an early patch for wv-1.2.0 support. Uses gsf-sharp to lookup the
metadata and then passes the gsf stream to wv, meaning that we don't open the
file twice.

Unfortunately it looks like the new wv is a bit slower.

This isn't finished yet - haven't though about any backwards compatibility and
page/word counts arent being indexed.
Comment 2 Veerapuram Varadhan 2005-11-03 20:33:12 UTC
Created attachment 54294 [details] [review]
support for wv-1.2.0 and wv-1.0.x

The attached patch is updated to support wv-1.2.0 as well as 1.0.x.  It uses
gsf-sharp for meta-data parsing and wv for text parsing in MS word files.  And,
since, both PPT and DOC filters use gsf-sharp, they derive from a class called
FilterOle, which does the basic meta-data and Ole parsing.  This patch also
fixes a bug, which wasn't easily reproducible, 306812 and 31559.
Comment 3 Veerapuram Varadhan 2005-11-03 21:55:41 UTC
Thanks for the report.  Fixed in CVS.