After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 320308 - [matroska] set timestamps for buffers with ebml elements
[matroska] set timestamps for buffers with ebml elements
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Linux
: Normal enhancement
: 0.9.5
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2005-10-31 13:20 UTC by Josef Zlomek
Modified: 2005-11-01 09:25 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Timestamps for (almost) all buffers (2.01 KB, patch)
2005-10-31 13:23 UTC, Josef Zlomek 		committed Details | Review

Description Josef Zlomek 2005-10-31 13:20:46 UTC 
The attached patch causes the matroska muxer to set the timestamp of the
outgoing buffers containing ebml elements (i.e. non-data buffers) to the
timestamp is taken from the incoming buffers too. So all buffers (except file
headers) coming from matroska muxer are timestamped.
The benefit is that the elements after matroska muxer can get the timestamp when
reading first ebml elements and they do not have to wait for the data buffer.
Comment 1 Josef Zlomek 2005-10-31 13:23:04 UTC 
Created attachment 54125 [details] [review]
Timestamps for (almost) all buffers
Comment 2 Tim-Philipp Müller 2005-11-01 09:25:11 UTC 
Thanks, applied with one minor changes (set timestamp to CLOCK_TIME_NONE in
gst_ebml_write_reset() as well):

2005-11-01  Josef Zlomek  <josef dot zlomek at xeris dot cz>

       * gst/matroska/ebml-write.c: (gst_ebml_write_new),
       (gst_ebml_write_reset), (gst_ebml_write_element_new):
       * gst/matroska/ebml-write.h:
       * gst/matroska/matroska-mux.c: (gst_matroska_mux_write_data):
         Set timestamps on outgoing ebml headers as well, so that the
         element after matroskamux can get the timestamp already when
         reading the first ebml element and doesn't have to wait for
         the actual data buffer for that (#320308).

Cheers
 -Tim