GNOME Bugzilla – Bug 320246
patch for g_return_* macros in static functions
Last modified: 2008-03-28 14:34:10 UTC
Distribution/Version: Ubuntu/Dapper As per the details here http://mail.gnome.org/archives/performance-list/2005-October/msg00005.html Replacing g_return_ functions in internal (static) functions with g_assert macros. For now I've replaced bulk of the calls with g_assert(), and in some places 'if() return' calls. If someone can review the patch and let me know what else to fix/change, I'd be glad to work on them. Patch to follow
Created attachment 54092 [details] [review] patch for changing g_return_ macros in static function to g_assert() Attaching patch
Thanks for your efforts and your patch, and sorry for the late response! Maybe you could send this patch to the nautilus mailing list [1] for review? [1] http://mail.gnome.org/mailman/listinfo/nautilus-list
Ping. Updating version.
Thanks for your efforts! I committed a slightly modified version, which also uses g_asserts() for the g_return_val_if_fail(x, y) checks where you used if (!x) return y; I also replaced the g_return_val_if_fail() calls in static functions by asserts, and added some g_return_...() checks to the public API. http://svn.gnome.org/viewvc/eel?view=revision&revision=2098 Closing bug, marking as FIXED. It would be great if you could also do the same for Nautilus :).