After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 320169 - Bookmark menu crashes when all topics are deleted
Bookmark menu crashes when all topics are deleted
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: Bookmarks
git master
Other Linux
: Normal normal
: ---
Assigned To: Epiphany Maintainers
Marco Pesenti Gritti
Depends on:
Blocks:
 
 
Reported: 2005-10-29 12:44 UTC by Crispin Flowerday (not receiving bugmail)
Modified: 2005-10-30 13:52 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch to prevent running off end of array. (421 bytes, patch)
2005-10-30 04:19 UTC, Peter Harvey 		committed Details | Review

Description Crispin Flowerday (not receiving bugmail) 2005-10-29 12:44:34 UTC 
Remove all the topics, try to open the bookmark menu:

+ Trace 63779

Thread 1 (Thread -1227123008 (LWP 14578))

  • #0 __kernel_vsyscall
  • #1 __waitpid_nocancel
    from /lib/tls/i686/cmov/libpthread.so.0
  • #2 libgnomeui_module_info_get
    from /usr/lib/libgnomeui-2.so.0
  • #3 nsProfileLock::FatalSignalHandler
    from /usr/lib/mozilla-firefox/libgtkembedmoz.so
  • #4 <signal handler called>
  • #5 ephy_nodes_get_covering
    at ephy-nodes-cover.c line 165
  • #6 append_menu
    at ephy-bookmarks-menu.c line 94
  • #7 ephy_bookmarks_menu_build
    at ephy-bookmarks-menu.c line 224
  • #8 activate_bookmarks_menu
    at ephy-bookmarks-ui.c line 86
  • #9 IA__g_cclosure_marshal_VOID__VOID
    at gmarshal.c line 77 






Comment 1


Peter Harvey





          2005-10-30 04:19:17 UTC
        



Created attachment 54068 [details] [review]
Patch to prevent running off end of array.

I forgot an array bounds check. The loop was otherwise guaranteed to finish
safely, so long as one topic existed. The bounds check isn't quite necessary
(testing parents->len==0 is sufficient), but is the safest way to go.






Comment 2


Christian Persch





          2005-10-30 13:52:55 UTC
        



Thanks for the patch!
Fixed in cvs.