After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 320072 - [matroskamux] needs better handling of VBR input
[matroskamux] needs better handling of VBR input
Status: RESOLVED OBSOLETE
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Linux
: Normal enhancement
: NONE
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2005-10-28 11:27 UTC by Tim-Philipp Müller
Modified: 2007-03-02 17:30 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Tim-Philipp Müller 2005-10-28 11:27:58 UTC
Scenario:

 filesrc location=vbr.mp3 ! mad ! vorbisenc ! matroskamux ! filesink

At some point at the beginning matroskamux sends a duration query upstream to
query the total duration for the headers. At this point mad might not
necessarily have a good approximate value for the total duration yet, not to
mention an exact value, so matroskamux stores a way-off duration value in its
header.

I wonder if that can be improved somehow. flacenc for example makes downstream
(filesink) seek back to the beginning of the file at EOS and overwrites the
previous header values with more accurate headers. Maybe matroskamux can do that
as well? 

Or maybe we can append an index from which the demuxer can then deduce the real
length?

Cheers
 -Tim
Comment 1 Tim-Philipp Müller 2005-10-28 11:29:57 UTC
Erm, the above pipeline lacks an audioconvert element of course ;)
Comment 2 Michal Benes 2005-10-28 14:46:31 UTC
In the moment, matroska muxer uses seeking really extensively (I was thinking
about some redesigning this behavior when I was porting the muxer, but thyen I
decided it is better to start with something that is known to work and refactor
the code later). 

So I think the best solution for now is to take the "flacenc approach". I will
think about it and provide a patch.
Comment 3 Michal Benes 2007-03-02 14:25:22 UTC
This feature is already implemented. Matroskamux rewrites total duration at the end of muxing.
Comment 4 Tim-Philipp Müller 2007-03-02 17:30:30 UTC
> This feature is already implemented. Matroskamux rewrites total duration at the
> end of muxing.

Excellent, will close this then.