After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 320065 - Fix GList leaks
Fix GList leaks
Status: RESOLVED FIXED
Product: evolution-data-server
Classification: Platform
Component: Contacts
1.4.x (obsolete)
Other Linux
: Normal normal
: ---
Assigned To: evolution-addressbook-maintainers
Evolution QA team
Depends on:
Blocks:
 
 
Reported: 2005-10-28 10:32 UTC by Ross Burton
Modified: 2006-01-10 10:52 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Cleanup (1.18 KB, patch)
2005-10-28 10:32 UTC, Ross Burton 		none Details | Review

Description Ross Burton 2005-10-28 10:32:17 UTC 
We noticed that e-vcard.c leaks GList items when you delete attributes by using
g_list_remove_link instead of _delete_link, so searched the code for more bugs
like this and found some odd code in e-book-query.c which does
g_list_remove_link followed by g_list_free1, which is exactly what
g_list_delete_link does.

Attaching a patch to fix the leak, and to clean up the code in the latter case.
Comment 1 Ross Burton 2005-10-28 10:32:39 UTC 
Created attachment 53986 [details] [review]
Cleanup
Comment 2 André Klapper 2005-11-14 01:02:24 UTC 
adding keyword, confirming.
Comment 3 Sushma Rai 2006-01-10 10:38:39 UTC 
patch looks good.
Comment 4 Ross Burton 2006-01-10 10:52:36 UTC 
Committed to HEAD, thanks.