After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 319884 - rtpamrdec discards non-transmitted frames
rtpamrdec discards non-transmitted frames
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Linux
: Normal normal
: 0.10.3
Assigned To: Wim Taymans
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2005-10-26 18:19 UTC by Sebastien Cote
Modified: 2006-05-04 16:36 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Proposed fix (909 bytes, patch)
2005-10-26 18:22 UTC, Sebastien Cote 		none Details | Review
Proposed fix (1.16 KB, patch)
2006-02-16 21:50 UTC, Sebastien Cote 		committed Details | Review

Description Sebastien Cote 2005-10-26 18:19:05 UTC 
When the RTP depacketizer for AMR-NB (amrnbdec) receives a frame of type 15
(frame size = 0), the packet is discarded. The packet should be used to let the
decoder know about this frame.

This happens often when DTX is enabled. After the first SID frame you can
encounter these frames.
Comment 1 Sebastien Cote 2005-10-26 18:22:21 UTC 
Created attachment 53916 [details] [review]
Proposed fix

This patch keeps the non-transmitted frames instead of discarding them.
Comment 2 Wim Taymans 2006-02-16 17:35:19 UTC 
some changes were made to amrdepay can you provide an updated patch?
Comment 3 Sebastien Cote 2006-02-16 21:50:38 UTC 
Created attachment 59529 [details] [review]
Proposed fix

Updated the patch against CVS version. I haven't tested this updated version, but the update was very straightforward.
Comment 4 Sebastien Cote 2006-02-17 14:56:24 UTC 
I tested the new patch and it fixes the problem.
Comment 5 Wim Taymans 2006-02-17 15:41:31 UTC 
        * gst/rtp/gstrtpamrdepay.c: (gst_rtp_amr_depay_chain):
        Patch from Sebastien Cote, fixes #319884