After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 319753 - malformed link to external stylesheet in html files
malformed link to external stylesheet in html files
Status: RESOLVED FIXED
Product: bluefish
Classification: Other
Component: application
1.0.1
Other All
: Normal enhancement
: ---
Assigned To: Bluefish Maintainer(s)
Bluefish Maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2005-10-25 15:01 UTC by Duncan Lithgow
Modified: 2005-11-03 17:05 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Duncan Lithgow 2005-10-25 15:01:16 UTC
Please describe the problem:
the dialog in "dialogs > css > link to stylesheet" insert an html link but
misses the rel="stylesheet" attribute - so the link is not understood or used by
the browser.

Steps to reproduce:
1. Place curser in and html file
2. goto 'dialogs > css > link to stylesheet' and select a file
3. 


Actual results:
<link href="files/assetts/style/style.css" type="text/css" media="screen">

Expected results:
<link href="files/assetts/style/style.css" rel="stylesheet" type="text/css"
media="screen">

Does this happen every time?
yes

Other information:
Comment 1 Daniel Leidert 2005-10-25 15:24:13 UTC
You get 'rel="Stylesheet"' by choosing "Stylesheet" for "Forward Relation:".

We should rework the link dialog. Maybe we could add some defaults for
especially the stylesheet link dialog. Or maybe it should be split(?). Ideas,
comments, concerns?

severity set to enhancement, confirmed
Comment 2 Daniel Leidert 2005-11-02 15:20:05 UTC
Ok. I reworked the dialog. If you now use "dialogs > css > link to stylesheet",
the dialog already contains the values for type, rel and media. More about this
can be found in src/plugin_htmlbar/html.c. Closing this bug now.
Comment 3 Duncan Lithgow 2005-11-02 19:38:53 UTC
Great, thanks for that Daniel.

I'm not sure that media is a required attribute in this tag (see:
http://www.htmlhelp.com/reference/css/style-html.html#external "The <LINK> tag
also takes an optional MEDIA attribute, which specifies the medium or media to
which the style sheet should be applied.")

So I would prefer it wasn't given a default value. Giving default values to
required attributes is to make the page work from the start, but doing the same
for non required attributes gets in the way of experienced users and dumbs down
the learning process for new users.

But that's just my opinion, and I support meritocracy, so you decide.

Duncan
Comment 4 Daniel Leidert 2005-11-03 11:11:21 UTC
You are right. Fixed. There is no default value for the media attribute.
Comment 5 Duncan Lithgow 2005-11-03 17:05:29 UTC
Lovely, this great program is now a bit better. Thanks.