GNOME Bugzilla – Bug 319727
imp/exp of .xls: pb of symbol for XY chart
Last modified: 2006-09-30 07:48:32 UTC
Version details: 1.6.0 - open the file with both gnumeric and XL => there are symbol for the chart in XL but not in gnumeric - save the file opened in gnumeric in .xls format => if you reopen it in XL, the symbols are still there. (that is to say, there is a problem for both the import and export filters).
Created attachment 53871 [details] The .xls file to reproduce the problem
I'll have a look at that one. Each time we fix a bug in this area, others appear :-(
Hmm, this is quite strange. It seems that the graphs have no marker as default, yet three series have markers and they are auto shaped... I made some tests. If a series is added to a scatter plot with no markers, it's style has no marker, not auto shape. I see only one solution for that, we should never use auto_shape = TRUE when loading an excel file. Unfortunately, I know Jody will not like this idea at all :-( auto_shape is not equivalent in excel and in gnumeric, this is the problem.
Created attachment 54229 [details] [review] a possible, but not perfect, patch I feel we can have auto_shape = FALSE only when needed with this patch.
Created attachment 54425 [details] [review] might be better We might disable the call of init_style on xl chart series import. It seems more logical and cleaner than the previous patch.
Created attachment 54426 [details] [review] the correspondig goffice patch
We would need to persist the 'is_xl' flag. This seems like a kludge.
OK, the only solution I can imagine now is to set the appropriate auto stuff to FALSE when importing series.
Bug still present in 1.6.3.
and in HEAD too, we never claimed it was fixed
Hi Jean, I never claimed you claimed it was fixed. ;-) More seriously, I tought it would help to test the bugs with a new version of gnumeric and to report if they are still valid or not.
Hi Frederic, thanks for reminding us these bugs. This one is not fixed because I could not come to an agreement with Jody about auto stuff. #319729 i has same problem. We do not have the same auto settings than xl, so we have three solutions: - either users wanting to have the same behavior do not use auto settings. - we never use auto settings when importing from excel. - we implement a special auto settings set for xls files. Both solution has its pros and its cons.
*** Bug 344954 has been marked as a duplicate of this bug. ***
Created attachment 73689 [details] [review] this patch should be acceptable. The trick is to ot use auto_shape for markers when the plot do not have markers and the series has. The same applies for line.auto_dash.
Patch applied to both branches.