After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 319727 - imp/exp of .xls: pb of symbol for XY chart
imp/exp of .xls: pb of symbol for XY chart
Status: RESOLVED FIXED
Product: Gnumeric
Classification: Applications
Component: import/export MS Excel (tm)
1.6.x
Other Linux
: Normal normal
: ---
Assigned To: Jean Bréfort
Jody Goldberg
: 344954 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2005-10-25 12:51 UTC by Frederic Parrenin
Modified: 2006-09-30 07:48 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
The .xls file to reproduce the problem (109.50 KB, application/vnd.ms-excel)
2005-10-25 12:52 UTC, Frederic Parrenin
  Details
a possible, but not perfect, patch (1.03 KB, patch)
2005-11-02 15:31 UTC, Jean Bréfort
none Details | Review
might be better (694 bytes, patch)
2005-11-07 15:34 UTC, Jean Bréfort
none Details | Review
the correspondig goffice patch (1.93 KB, patch)
2005-11-07 15:35 UTC, Jean Bréfort
rejected Details | Review
this patch should be acceptable. (2.33 KB, patch)
2006-09-30 06:56 UTC, Jean Bréfort
committed Details | Review

Description Frederic Parrenin 2005-10-25 12:51:33 UTC
Version details: 1.6.0

- open the file with both gnumeric and XL
=> there are symbol for the chart in XL but not in gnumeric
- save the file opened in gnumeric in .xls format
=> if you reopen it in XL, the symbols are still there.
(that is to say, there is a problem for both the import and export filters).
Comment 1 Frederic Parrenin 2005-10-25 12:52:35 UTC
Created attachment 53871 [details]
The .xls file to reproduce the problem
Comment 2 Jean Bréfort 2005-11-01 14:58:39 UTC
I'll have a look at that one. Each time we fix a bug in this area, others appear :-(
Comment 3 Jean Bréfort 2005-11-02 12:57:33 UTC
Hmm, this is quite strange. It seems that the graphs have no marker as default,
yet three series have markers and they are auto shaped...
I made some tests. If a series is added to a scatter plot with no markers, it's
style has no marker, not auto shape.
I see only one solution for that, we should never use auto_shape = TRUE when
loading an excel file. Unfortunately, I know Jody will not like this idea at all :-(
auto_shape is not equivalent in excel and in gnumeric, this is the problem.
Comment 4 Jean Bréfort 2005-11-02 15:31:20 UTC
Created attachment 54229 [details] [review]
a possible, but not perfect, patch

I feel we can have auto_shape = FALSE only when needed with this patch.
Comment 5 Jean Bréfort 2005-11-07 15:34:26 UTC
Created attachment 54425 [details] [review]
might be better

We might disable the call of init_style on xl chart series import. It seems
more logical and cleaner than the previous patch.
Comment 6 Jean Bréfort 2005-11-07 15:35:02 UTC
Created attachment 54426 [details] [review]
the correspondig goffice patch
Comment 7 Jody Goldberg 2005-11-08 23:55:39 UTC
We would need to persist the 'is_xl' flag.
This seems like a kludge.
Comment 8 Jean Bréfort 2005-11-09 07:36:58 UTC
OK, the only solution I can imagine now is to set the appropriate auto stuff to
FALSE when importing series.
Comment 9 Frederic Parrenin 2006-04-15 10:23:22 UTC
Bug still present in 1.6.3.
Comment 10 Jean Bréfort 2006-04-15 11:05:59 UTC
and in HEAD too, we never claimed it was fixed
Comment 11 Frederic Parrenin 2006-04-15 11:17:18 UTC
Hi Jean, I never claimed you claimed it was fixed. ;-)
More seriously, I tought it would help to test the bugs with a new version of gnumeric and to report if they are still valid or not.
Comment 12 Jean Bréfort 2006-04-15 11:33:12 UTC
Hi Frederic, thanks for reminding us these bugs. This one is not fixed because I could not come to an agreement with Jody about auto stuff. #319729 i has same problem. We do not have the same auto settings than xl, so we have three solutions:

- either users wanting to have the same behavior do not use auto settings.
- we never use auto settings when importing from excel.
- we implement a special auto settings set for xls files.

Both solution has its pros and its cons.
Comment 13 Jean Bréfort 2006-06-15 15:38:30 UTC
*** Bug 344954 has been marked as a duplicate of this bug. ***
Comment 14 Jean Bréfort 2006-09-30 06:56:44 UTC
Created attachment 73689 [details] [review]
this patch should be acceptable.

The trick is to ot use auto_shape for markers when the plot do not have markers and the series has. The same applies for line.auto_dash.
Comment 15 Jean Bréfort 2006-09-30 07:48:32 UTC
Patch applied to both branches.