After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 319537 - delete a folder with DEL should close its window
delete a folder with DEL should close its window
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: Trash
2.13.x
Other All
: Normal minor
: ---
Assigned To: Christian Neumair
Nautilus Maintainers
Depends on:
Blocks:
 
 
Reported: 2005-10-23 14:31 UTC by Hubert Figuiere (:hub)
Modified: 2006-03-03 13:43 UTC
See Also:
GNOME target: ---
GNOME version: 2.13/2.14


Attachments
Proposed patch (2.44 KB, patch)
2006-03-02 14:46 UTC, Christian Neumair
none Details | Review

Description Hubert Figuiere (:hub) 2005-10-23 14:31:56 UTC
Version details: 2.12.1-0ubuntu1
Distribution/Version: Ubuntu Breezy

moving a folder to the trash should close its window, in spatial mode.

the main reason behind that is that if you move a folder to the trash, it is
because you don't want to use it anymore. So there is no reason to keep its
window open and keep the desktop space cluttered.
Comment 1 Chris Altmann 2005-11-29 09:39:16 UTC
Note that Nautilus does close the folder if you drag the folder icon to the
trash , except under certain circumstances, which I've filed as bug 322737
Comment 2 Hubert Figuiere (:hub) 2005-12-03 17:48:35 UTC
But if you select the folder and press "Del" it does not. Tested on 2.13.2
Comment 3 Hubert Figuiere (:hub) 2006-01-23 17:33:13 UTC
re-titling bug to reflect the real problem
Comment 4 Hubert Figuiere (:hub) 2006-01-23 17:33:55 UTC
2.13.4 still has it.
Comment 5 Christian Neumair 2006-01-23 19:16:20 UTC
When moving folders to trash, at least my local Nautilus copy doesn't seem to close any window. CCing usability team to get some opinions.
Comment 6 Hubert Figuiere (:hub) 2006-01-23 20:29:31 UTC
actually I rechecked and that's were it is nuts.

Drag -> desktop trash does nothing
Delete does nothing
Drag -> trash applet DOES close the window.


IMHO the trash applet get it right, not the others.

If you want to get rid of a folder, why keeping it open?
Comment 7 Calum Benson 2006-01-24 15:48:22 UTC
Interestingly, OS X keeps trashed folder windows open too.  Inclined to agree with everyone here,though, I can't think of any particularly good reason to do so.
Comment 8 Christian Neumair 2006-01-24 15:58:03 UTC
Destroying a focused window might not be the best choice, so we may want to filter out those. Maybe we could add a hint like "(in Trash)" to the titlebar for trashed folders in general.
Comment 9 Hubert Figuiere (:hub) 2006-01-26 02:14:45 UTC
well, in that case there are chance it is not focused because you delete the folder in the parent window. And given it is inside nautilus, I don't we why we can't close the windows as there are other features that close the window.
Comment 10 Christian Neumair 2006-03-02 14:46:30 UTC
Created attachment 60495 [details] [review]
Proposed patch

Also submitted to nautilus-list for review:

http://mail.gnome.org/archives/nautilus-list/2006-March/msg00010.html
Comment 11 Christian Neumair 2006-03-02 14:48:11 UTC
Note that this patch will close both spatial and navigational windows vieweing the trashed file, for making the behavior consistent with the trash applet.
Comment 12 Alexander Larsson 2006-03-03 13:43:44 UTC
Commited.