After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 319406 - ffdec crash when going to READY
ffdec crash when going to READY
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-libav
git master
Other Linux
: Normal normal
: 0.9.x
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2005-10-21 12:55 UTC by Michal Benes
Modified: 2005-12-05 13:39 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch to fix get_buffer() behavior (1.22 KB, patch)
2005-10-21 12:57 UTC, Michal Benes 		rejected Details | Review

Description Michal Benes 2005-10-21 12:55:21 UTC 
The get_buffer function tries to allocate a new buffer by gst_pad_alloc_buffer,
what fails when the pipe is going to READY state. The error message is
ERROR (0x825cd60 - 0:00:06.327547000)               ffmpeg(12274) (0)::
get_buffer() failed (-1 2147483647 2 (nil))
Immediately after that, the application crashes on segfault.
Comment 1 Michal Benes 2005-10-21 12:57:31 UTC 
Created attachment 53728 [details] [review]
Patch to fix get_buffer() behavior

This patch implement fallback to gst_buffer_new_and_alloc in
gstffmpegdec.c:get_buffer() if gst_pad_alloc_buffer fails.

This had fixed the crash for me.
Comment 2 Ronald Bultje 2005-10-24 13:52:59 UTC 
You probably need to return from the loop then, because !GST_FLOW_OK means "stop
processing". So the patch is wrong.
Comment 3 Michal Benes 2005-10-24 14:07:02 UTC 
Fine, I will try to find the correct solution.
Comment 4 Michal Benes 2005-12-05 13:39:19 UTC 
This problem can not be reproduced anymore. It seems that the real problem was
solved.