After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 319395 - Macro name/visibility API bugs
Macro name/visibility API bugs
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
0.9.x
Other Linux
: Normal normal
: 0.9.6
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks: 319388
 
 
Reported: 2005-10-21 10:40 UTC by Andy Wingo
Modified: 2005-11-21 17:36 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Andy Wingo 2005-10-21 10:40:15 UTC 
It's badly named for public API, and also it's not part of basesrc's public API.
Comment 1 Andy Wingo 2005-10-21 10:48:28 UTC 
I renamed this bug from "make GST_LIVE_LOCK private to gstbasesrc".
Comment 2 Andy Wingo 2005-10-21 11:02:16 UTC 
Other problems:

GST_GET_LOCK => GST_OBJECT_GET_LOCK

GST_[UN]LOCK => GST_OBJECT_[UN]LOCK
  not sure about this one

GST_PREROLL_*
  should be private to basesink

GST_STATE_*LOCK
  macros should go in gstelement.c, lock should be private in GstElement
  structure

GST_STREAM*
  either GST_PAD_LOCK_STREAM or GST_PAD_STREAM_LOCK, dunno which, I like
  the first, wim likes the second

GST_IS_PAD_FAST
  should go, no one is using it
Comment 3 Andy Wingo 2005-11-21 16:00:19 UTC 
Unfortunately the GST_STATE macros have to stay, they are used by other things :-/
Comment 4 Andy Wingo 2005-11-21 17:36:01 UTC 
All fixed. PREROLL had moved to gstpad.c, so it had to stay -- renamed to
GST_PAD_PREROLL_...