After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 319340 - [cdparanoia] uncorrected-error signal never fired
[cdparanoia] uncorrected-error signal never fired
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other All
: Normal normal
: 0.10.4
Assigned To: Andy Wingo
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2005-10-20 18:25 UTC by Rod Begbie
Modified: 2006-02-17 16:15 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Rod Begbie 2005-10-20 18:25:40 UTC 
When ripping CDs using the cdparanoia plugin in a gst-python program, the
exposed uncorrected-error and smilie-change signals never seem to be fired, even
when the CD is unreadable.

This means it's impossible to know if the track was ripped successfully without
listening to the resulting file.
Comment 1 Tim-Philipp Müller 2006-01-10 18:05:57 UTC 
Not sure how easy it is to fix that given that there isn't really an easy way to find our element object from within the paranoia_callback function (as far as I can tell, at least).
Comment 2 Tim-Philipp Müller 2006-01-10 19:20:34 UTC 
On second thought, we could serialise the cdparanoia_read() calls for all cdparanoiasrc instances that have the NEVERSKIP flag set via a global lock and then set a global variable to the currently reading element, but that seems rather ugly to me ...
Comment 3 Wim Taymans 2006-02-16 17:02:17 UTC 
amazing... serializing would be ugly but certainly possible.
Comment 4 Tim-Philipp Müller 2006-02-16 17:17:08 UTC 
Let's do that then. Got a patch for that somewhere, I'll see if I can find it.
Comment 5 Tim-Philipp Müller 2006-02-17 16:15:41 UTC 
2006-02-17  Tim-Philipp Müller  <tim at centricular dot net>

        * ext/cdparanoia/gstcdparanoiasrc.c:
        (gst_cd_paranoia_src_class_init), (gst_cd_paranoia_dummy_callback),
        (gst_cd_paranoia_paranoia_callback),
        (gst_cd_paranoia_src_signal_is_being_watched),
        (gst_cd_paranoia_src_read_sector):
        * ext/cdparanoia/gstcdparanoiasrc.h:
          Add back 'transport-error' and 'uncorrected-error' signals and
          make them actually be fired when bad stuff happens (#319340).