GNOME Bugzilla – Bug 319320
rhythmbox is not able to show song lyrics on demand
Last modified: 2006-06-11 08:56:17 UTC
The feature to look up lyrics online and display them is not included. I love this feature in quod libet, but I prefer rhythmbox anyway, so I hope you will indlude this. Kind regards, Martin Seifert
Probably should be done as a plugin. Changing component.
Created attachment 63572 [details] [review] first attempt Stolen wholesale from quod libet. Blocks the UI while retrieving lyrics, which sucks a bit.
Successfully installed plugin, get "Song Lyrics" in View menu, highlight a track and select "Song Lyrics", but nothing happens. What is supposed to happen, a pop-up?
It only gets the lyrics for the playing track, and should probably disable the menu item when nothing is playing. Works fine for me, aside from sometimes picking the wrong song.
Ah, didn't know it had to be playing. OK, it seems to be working now. I guess it would be nice to cache the results somewhere and an option to display them in song-properties or the right-click menu or something (amarok does something like this). But good first start.
Created attachment 64271 [details] [review] somewhat better Now does http requests asynchronously using gnomevfs if available, falling back to urllib if not. It should also be easier to add alternate lyrics providers such as lyrc.com.ar.
One possible addition would be lyric caching, we could probably use "~/.gnome2/rhythmbox/lyrics/Artist - Title.txt" or similar.
Created attachment 65494 [details] [review] more interesting patch This gives plugins the ability to add pages to the notebook used in the song info window (modifying the multiple-entry window so everything's inside a notebook), and adds a 'lyrics' page to the single-entry song info window.
Looks fairly good to me, aside from a couple of minor things. This is probably comittable if you're happy with it. * it doesn't set the text to "searching for lyrics" when first created, only when you change the entry. * the text view should be made uneditable, until we support saving them somewhere.
The song properties window really doesn't seem like a good idea to place the lyrics. For starters, you have to right click the song you are playing to get the lyrics (and that's for every song). Perhaps if the browser+search+song_tree are in one page of a notebook, and the lyrics are on another page, it will be better (that way even more ui stuff like visualization can be added later)
The plugin also adds a view->song lyrics menu item to display the lyrics for the playing song. This currently brings up a new window, but I think I'd prefer it if it was integrated into the main window. I'm not sure of the right way to do this, but I don't think adding a page to the source notebook is it. If we start doing that for other features, then I'll take another look at it. I've committed it with the fixes suggested above, and some minor changes to make it use a copy of the Loader module from the artdisplay plugin. Slightly better than having code duplication inside the plugin itself.
I missed the view->song part. But that still just displays the current song, and after the song changes, it doesn't go off searching for the new lyrics.
Any suggestions about putting things (like lyrics) in the main UI should be done on bug 342207, which I've just filed.
Now that this bug is marked "resolved", I just wanted to thank you. I tried it out with rhythmbox-0.9.4.90-1 from Debian SID and I really like the plugin. Best regards Martin