After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 318878 - gconf-editor crashes on f1 if yelp is not present
gconf-editor crashes on f1 if yelp is not present
Status: RESOLVED FIXED
Product: gconf-editor
Classification: Applications
Component: general
2.12.x
Other Linux
: High normal
: ---
Assigned To: Gconf Editor Maintainers
Gconf Editor Maintainers
Depends on:
Blocks:
 
 
Reported: 2005-10-14 17:00 UTC by Gustavo Noronha (kov)
Modified: 2005-11-29 20:25 UTC
See Also:
GNOME target: ---
GNOME version: 2.11/2.12

Attachments
patch fixing it (846 bytes, patch)
2005-10-14 20:47 UTC, Felix Riemann 		committed Details | Review

Description Gustavo Noronha (kov) 2005-10-14 17:00:22 UTC 
Distribution/Version: Debian unstable

Reported here: http://bugs.debian.org/315129

If I don't have yelp installed gconf-editor will crash when I press f1 or
otherwise activate the help system. It's easily reproducable by doing mv
/usr/bin/yelp{,.old} and pressing f1.

I can reproduce with 2.10 and 2.12 versions.
Comment 1 Felix Riemann 2005-10-14 20:47:13 UTC 
Created attachment 53496 [details] [review]
patch fixing it

This patch fixes it.
The function gconf_editor_window_popup_error_dialog(..),which pops up the error
dialog, expects a GError as last argument. In this case there was only the
error message not the whole GError submitted.
I wonder why gcc didn't complain about the type mismatch here.
Comment 2 Sebastien Bacher 2005-11-20 14:50:27 UTC 
Thanks for your patch
Comment 3 Sebastien Bacher 2005-11-27 14:41:00 UTC 
can we get this patch accepted now?
Comment 4 Sebastien Bacher 2005-11-29 20:25:46 UTC 
Thanks for your patch, that's fixed with the CVS now:

2005-11-29  Sebastien Bacher  <seb128@debian.org>

	* src/gconf-editor-window.c: (help_cb):
	fix a crasher when pressing F1 without yelp installed,
	patch by Felix Riemann <felix@hsgheli.de> (Closes: #318878).