Created attachment 53452 [details] [review]
Ported a52dec

Thanks for the port and apologies that no one has looked at it yet. Will do so
as soon as possible if no one else does it first.

 Cheers
  -Tim
 

Applied with minor changes:
 - cast to GST_OBJECT is not required for gst_object_unref()
 - Makefile.am needs GST_PLUGINS_BASE_CFLAGS and _LIBS for the audio stuff
 - no more buffer-frames for float audio in 0.9
 - use GST_DEBUG_FUNCPTR for pad functions for nicer debugging output
 - handle TAG+EOS events in sink event function and pass on with stream lock
   (both should be interleaved with the data stream)
 - remove GST_STREAM_LOCK() around default handler (other events don't need
   to be interleaved with the data stream)
 - make state change function thread-safe


2005-10-20  Josef Zlomek  <josef dot zlomek at xeris dot cz>

        * configure.ac:
        * ext/a52dec/Makefile.am:
        * ext/a52dec/gsta52dec.c:
        * ext/a52dec/gsta52dec.h:
          Port AC3 decoder to 0.9 (#318849).

Many thanks again.

 Cheers
  -Tim

Hi Josef,
I was testing this today on the .vob files we have on
gstreamer.freedesktop.net/media/large. All of them failed with this message
** Message: don't know how to handle audio/x-private1-ac3

Any chance you could update the a52dec plugin to support this?

I have just ported the codec from gstreamer 0.8 to 0.9. I do not know what
audio/x-private1-ac3 is etc.

Sorry for this, it seems its related to demuxer functionality. Tim will take
care of it.