GNOME Bugzilla – Bug 318847
Matroska muxer port to 0.9
Last modified: 2005-10-21 16:32:17 UTC
Matroska muxer port to 0.9, the original version was taken from 0.8.11 not 0.9 as suggested.
Created attachment 53451 [details] [review] Matroska muxer port to 0.9 The patch was tested by Valgrind, I have seen no obvious errors, leeks, etc... originated from matroskamux.
Cool, thanks! I've committed this with minor fixes (change c++-style comments in matroska-ids.h to C-style comments, add GST_BASE_LIBS to LIBADD for gstcollectpads to Makefile.am). Here's a crasher though (only noticed just after the commit): gst-launch-0.9 videotestsrc num-buffers=500 ! ffenc_mpeg4 ! matroskamux ! filesink location=foo.mkv ffenc_msmpeg4 works fine though (and the resulting file plays back in vlc). When doing gst-launch-0.9 videotestsrc num-buffers=500 ! matroskamux ! filesink location=foo.mkv vlc says "no suitable decoder module for fourcc 'undf'" - is that the right format for raw yuv/rgb/whatever, or does that need some more fine-tuning? Leaving bug open for now until the above issues are fixed. Cheers -Tim
I will look at the crash problem. Muxing raw video worked for me. I have not tested with vlc but encoding by gst-launch videotestsrc ! matroskamux ! filesink location=foo.mkv worked with MPlayer. I can not test this just now. But I will try realy soon.
Created attachment 53573 [details] [review] Fix to caps negotiation. There was a typo in the original matroska code which made mpeg4 muxing crash. I have added default statements to all switches in caps negotiation to prevent this type of bugs in future. PS.: Please, feel free to contact me if you find any other bugs in matroska code, I am quite interested in "maintaining" it.
OK, one more comment: gst-launch-0.9 videotestsrc num-buffers=500 ! ffenc_mpeg4 ! matroskamux ! filesink location=foo.mkv creates damaged video for me (colorbars are totaly wrong), but gst-launch-0.9 videotestsrc num-buffers=500 ! ffmpegcolorspace ! ffenc_mpeg4 ! matroskamux ! filesink location=foo.mkv works for me. The same is with all other codecs I have tested so far. Do you see the same? It is probably a bug in videotestsrc.
Sorry, I was lying (well, not intentionaly ;) when saying that I was able to play files created by gst-launch-0.9 videotestsrc num-buffers=500 ! matroskamux ! filesink location=foo.mkv by mplayer. MPlayer does not support uncompressed video in mkv.
Regarding the messed up color bars: what liboil version are you using? Do you get the same with videotestsrc ! video/x-raw-yuv,format=\(fourcc\)I420 ! xvimagesink if yes, then that's probably a liboil bug that was fixed in 0.3.3. Cheers -Tim
Thank you, the problem with the colorbars was indeed the liboil bug. The crasher is fixed now - I think we can close the bug. Cheers Michal