GNOME Bugzilla – Bug 318461
tab close buttons are cropped
Last modified: 2008-02-11 19:49:15 UTC
This applies to both the gnome 2.12 version as well as new_mdi branch: Take a look at the close buttons in the tab labels; they're cropped. This is because you're setting their size request too small, which was only noticeable after gtk+ 2.4.x fixed the button allocations. Epiphany had the same bug, #144772.
so we need a custom icon... if we go this way. I'd love to use the one used in MonoDevelop or the one used in the gimp. What do you guys think?
I don't know, changing icon will increase incosistence among desktop apps. BTW, we can try to change it and if it looks better eventually make the same change in the other MDI app in desktop (I think epiphany is the only one). Christian: what do you think? BTW, this bug need to be fixed in new_mdi.
Epiphany already installs its own themeable icon (10x10 which is the largest size we found would give acceptable tab label height) and icon size (not sure if that's themeable). I'd love a better solution, but we didn't find one when we worked on bug 144772.
Christian, yup, I saw... Christian what do you think of the icon used by MonoDevelop instead of the current one?
It looks a bit better since it looks the same as metacity's window close button, yes. (And I noticed that monodevelop 0.7 has the same bug in the notebook labels!)
Ok, I'm probably just dumb, but this thing is pissing me off to no end :( I tried with various combinations but I always ended up either with the image cropped or with tabs larger than they are now which is a real waste of vertical space (note that epi tab are currently larger than gedit ones). I'll at least attach gedit-stock.ch and the image used by gdl but scaled to 10x10 so that at least we don't have to start from scratch when giving another go at this
Created attachment 53480 [details] stock-close-tab-10.png
Created attachment 53481 [details] gedit-stock.c
Created attachment 53482 [details] gedit-stock.h
> I tried with various combinations but I always ended up either with the image > cropped or with tabs larger than they are now which is a real waste of vertical > space (note that epi tab are currently larger than gedit ones). That's the reason the tabs are larger in Epiphany :) If you really want to hack around that, maybe you could look at how galeon has fixed this; they use a rc style to set [xy]thickness to 0...
Created attachment 53514 [details] [review] patch This patch fixes the cropping issue using the galeon trick. (Without switching icon yet). It's a hack, but less hackish than what we are doing right now, and seems to work nicely for me so I am committing it to new_mdi. Maybe we should do the same also for 2.12.2... Later we can look into using a different icon.
*** Bug 337860 has been marked as a duplicate of this bug. ***
Is the "trick" mentioned in comment #11 already active in the stable version? The close icon in gedit 2.14.1 is still cropped. However, the close icon displays correctly in Epiphany 2.14.0 and also in GNOME Terminal 2.14.0. As opposed to the statement from comment #10, I don't have the impression their tabs are any larger than the ones from gedit. I have no idea about their technical underpinnings though.
pbor's patch (comment #11) has been committed in CVS, in both HEAD and GNOME-2-14 branches.
Created attachment 104980 [details] Reproduction of issue on GNOME 2.21 I'm still seeing this in GNOME 2.21 using the Clearlooks theme and the Tango icons (using a Close icon newer than the discussion here, IIRC). I don't have this issue in other tabbed applications, e.g. gnome-terminal or epiphany (or even Firefox 3). Is my issue different than what was mentioned here?
It's a new issue, see ephy bug 499983.
(In reply to comment #16) > It's a new issue, see ephy bug 499983. Maybe I'm misunderstanding, but I'm seeing this bug in gedit, but not in Epiphany. The close button is too narrow for the image. Maybe somehow related to the extra icon in gedit's tabs?