After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 318353 - [ffmpegcolorspace] forward-port fixes from 0.8 branch
[ffmpegcolorspace] forward-port fixes from 0.8 branch
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Linux
: Normal normal
: 0.9.6
Assigned To: Andy Wingo
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2005-10-09 19:49 UTC by Luca Ognibene
Modified: 2005-11-22 09:24 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch (4.99 KB, patch)
2005-10-09 19:50 UTC, Luca Ognibene 		committed Details | Review

Description Luca Ognibene 2005-10-09 19:49:24 UTC 
This patch ports all commits done to ffmpegcolorspace in the 0.8 branch from
22/02/2005 to today.

I've not ported only this commit:

* gst/ffmpegcolorspace/gstffmpegcolorspace.c:
(gst_ffmpegcsp_base_init), (gst_ffmpegcsp_class_init),
(gst_ffmpegcsp_fixate_field_nearest_int), (gst_ffmpegcsp_fixate),
(gst_ffmpegcsp_init):
Add a fixate function to both pads to make sure we don't fixate to
silly values like, say, 8bpp RGB video, if we can just as well do
better (#164176, #318136); also some minor code clean-ups.

if someone wants to port it.. :)
Comment 1 Luca Ognibene 2005-10-09 19:50:06 UTC 
Created attachment 53260 [details] [review]
patch
Comment 2 Tim-Philipp Müller 2005-10-09 19:56:58 UTC 
FWIW, I haven't committed the patch you mention to HEAD because HEAD didn't
exhibit the problem that the patch fixed in 0.8, and because I wasn't sure how
exactly this was supposed to be done in 0.9.

 Cheers
  -Tim
Comment 3 Luca Ognibene 2005-11-11 15:37:23 UTC 
i'll commit this as soon as the new release is out if nobody is against it..
Comment 4 Tim-Philipp Müller 2005-11-15 23:52:31 UTC 
I think you can commit this now. The patch is not very intrusive in any case.

Cheers
 -Tim
Comment 5 Tim-Philipp Müller 2005-11-22 09:24:58 UTC 
2005-11-22  Tim-Philipp Müller  <tim at centricular dot net>

        * gst/ffmpegcolorspace/gstffmpegcodecmap.c:
        (gst_ffmpeg_pixfmt_to_caps), (gst_ffmpeg_caps_to_pixfmt):
        * gst/ffmpegcolorspace/gstffmpegcolorspace.c:
        (gst_ffmpegcsp_caps_remove_format_info):
        * gst/ffmpegcolorspace/imgconvert.c:
        * gst/ffmpegcolorspace/imgconvert_template.h:
          Forward-port fixes from the 0.8 branch (patch by Luca Ognibene,
          #318353); use gst_structure_has_name().