After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 318278 - Nautilus bookmark editing doesn't save correctly
Nautilus bookmark editing doesn't save correctly
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: Bookmarks
2.21.x
Other Linux
: Normal normal
: 2.24.x
Assigned To: Christian Neumair
Nautilus Maintainers
: 522358 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2005-10-08 11:47 UTC by Sebastien Bacher
Modified: 2008-03-29 09:51 UTC
See Also:
GNOME target: ---
GNOME version: 2.21/2.22


Attachments
Proposed patch (6.07 KB, patch)
2008-03-14 19:43 UTC, Christian Neumair
committed Details | Review

Description Sebastien Bacher 2005-10-08 11:47:53 UTC
This bug has been opened here: https://bugzilla.ubuntu.com/show_bug.cgi?id=17288

"The "Edit Bookmarks" dialog in Nautilus is very non-intuitive to use.

Steps to reproduce problem:
1) Create two or more bookmarks in Nautilus
2) Select "Edit Bookmarks"
3) In the Edit dialog, select a bookmark and rename it. Note that the name in
the list on the left changes to match the edit
4) Click on another bookmark name in the list
5) Edit second bookmark
6) Click close

Result: only the second bookmark rename is remembered - all other edits are
abandoned. You can force the changes to be saved by pressing enter after every
rename, but this is not clear from the dialog.

I think the expected behaviour would be that changes are either saved
immediately on renaming, or when the rename text box loses focus."
Comment 1 Teppo Turtiainen 2006-09-03 20:00:36 UTC
Confirmed with Nautilus 2.14.3 on Ubuntu Dapper.
Comment 2 Oliver Gerlich 2008-03-06 22:52:11 UTC
Just noticed that this also happens in Nautilus 2.21.93 (Ubuntu Hardy Alpha).
Comment 3 Cosimo Cecchi 2008-03-14 10:07:27 UTC
*** Bug 522358 has been marked as a duplicate of this bug. ***
Comment 4 Christian Neumair 2008-03-14 19:43:48 UTC
Created attachment 107316 [details] [review]
Proposed patch

This patch ensures that the old selection is restored when repopulating the bookmark list, and that changes in the text field are written back before the tree selection is changed.
Comment 5 Christian Neumair 2008-03-29 09:51:05 UTC
Committed to trunk and GNOME 2.22 branch (will be incorporated in Nautilus 2.22.2):

http://svn.gnome.org/viewvc/nautilus?view=revision&revision=13996
http://svn.gnome.org/viewvc/nautilus?view=revision&revision=13997

Closing.