Bug 318193 – Corrupted favicons in moz bookmarks crash taskbar applet

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 318193 - Corrupted favicons in moz bookmarks crash taskbar applet


Summary:	Corrupted favicons in moz bookmarks crash taskbar applet


Status:	RESOLVED FIXED

Product:	deskbar-applet
Classification:	Deprecated
Component:	general
Version:	Git master
Hardware:	Other Linux

Importance:	Normal normal
Target Milestone:	---
Assigned To:	Deskbar Applet Maintainer(s)
QA Contact:	Deskbar Applet Maintainer(s)

URL:
Whiteboard:

Depends on:
Blocks:

Reported:	2005-10-07 11:40 UTC by palfrey
Modified:	2005-10-07 16:52 UTC

See Also:
GNOME target:	---
GNOME version:	---

Attachments
Fix for the bug (by catching the exception) (886 bytes, patch) 2005-10-07 11:41 UTC, palfrey	none	Details \| Review

Description palfrey 2005-10-07 11:40:52 UTC

Run /usr/libexec/deskbar-applet -w with dodgy bookmarks. Get the following traceback

Starting mozilla/ff bookmarks indexation
Traceback (most recent call last):

+ Trace 63414

File "/usr/libexec/deskbar-applet", line 84 in ?
```
build_window()
```
File "/usr/libexec/deskbar-applet", line 45 in build_window
```
applet_factory(applet, None)
```
File "/usr/libexec/deskbar-applet", line 34 in applet_factory
```
deskbar.applet.DeskbarApplet(applet)
```
File "/usr/lib/python2.4/site-packages/deskbar/applet.py", line 9 in __init__
```
self.entry = deskbar.deskbarentry.DeskbarEntry()
```
File "/usr/lib/python2.4/site-packages/deskbar/deskbarentry.py", line 54 in __init__
```
self._handlers = self._load_handlers()
```
File "/usr/lib/python2.4/site-packages/deskbar/deskbarentry.py", line 94 in _load_handlers
```
return [
```
File "/usr/lib/python2.4/site-packages/deskbar/handlers/mozilla.py", line 28 in __init__
```
parser = MozillaBookmarksParser(self)
```
File "/usr/lib/python2.4/site-packages/deskbar/handlers/mozilla.py", line 65 in __init__
```
self._index_firefox()
```
File "/usr/lib/python2.4/site-packages/deskbar/handlers/mozilla.py", line 111 in _index_firefox
```
self.feed(file(bookmarks_file).read())
```
File "/usr/lib/python2.4/HTMLParser.py", line 108 in feed
```
self.goahead(0)
```
File "/usr/lib/python2.4/HTMLParser.py", line 150 in goahead
```
k = self.parse_endtag(i)
```
File "/usr/lib/python2.4/HTMLParser.py", line 316 in parse_endtag
```
self.handle_endtag(tag.lower())
```
File "/usr/lib/python2.4/site-packages/deskbar/handlers/mozilla.py", line 134 in handle_endtag
```
loader.write(base64.b64decode(content))
```

gobject.GError: Unrecognized image file format

Comment 1 palfrey 2005-10-07 11:41:31 UTC

Created attachment 53177 [details] [review]
Fix for the bug (by catching the exception)

Comment 2 Raphael Slinckx 2005-10-07 16:52:39 UTC

Thanks for the report ! I fixed this in CVS slightly differently, but the idea
is the same :)