GNOME Bugzilla – Bug 318049
UML transition arrows point the wrong direction
Last modified: 2005-10-08 21:36:25 UTC
Please describe the problem: The arrow on the UML transitions points in the opposite direction of how the transition was drawn by the user. Steps to reproduce: 1. Select the transition icon in the UML group in the Diagram Editor 2. Move the mouse pointer to a place in the diagram, then press and hold the mouse button 3. Drag the pointer to another place in the diagram then release the mouse button Actual results: The new transition should point from where the button was pressed to where it was released Expected results: The new transition points from where the button was released to the place it was pressed. Does this happen every time? Yes Other information:
Created attachment 53074 [details] [review] Patch that should fix the bug This patch tries to resolve the bug by switching the NULL and the pointer to an Arrow object in the call to draw_polyline_with_arrows(). In order to stay compatible with old files it also increments the version number, and keeps track of whether a given transition was created with the arrow direction inverted or not. I don't know what this projects policiy regarding compatibility with files generated by unreleased software is. But some complexity (both in the code and XML file) can be removed, if we ignore the troubles caused by files generated with versions not containing the fix.
I'm not sure what you mean with unreleased version. Although Dia still has a version below number 1.0 there have been quite a bunch of releases already. And we take backward compatibility quite serious. BTW: your patch looks just right, applied to cvs. Thanks, Hans 2005-10-08 Hans Breuer <hans@breuer.org> * objects/UML/transition.c : inverted default direction of the direction. Patch from Peter Allin, fixes bug #318049 [You possibly need to 'rm ~/.dia/defaults.dia' to have an effect]