GNOME Bugzilla – Bug 318044
sound-juicer doesn't handle multiple choices for a cdid correctly
Last modified: 2006-03-10 10:38:12 UTC
Version details: 2.12.2-0ubuntu1 Distribution/Version: Ubuntu Development Breezy from http://bugzilla.ubuntu.com/show_bug.cgi?id=15220 "When I try to rip "Shirei Moledet A-B" (http://musicbrainz.org/album/3a84c98a-d23e-43d2-b40e-c7ca713bb3f9.html and http://musicbrainz.org/album/50041899-12ca-412d-9271-4752fe4c8d33.html), it gives me two options that are both Sirei Moledet A-B. It doesn't give שירי מולדת א'■ב' as an option." Also, the two options are the same (not just the same name). If anybody wants me to, I could provide a toc and zeroed bin files so you can burn this cd (with no audio of course).
I'd really like a TOC file for this album, not only for this bug but it's also got metadata in a non-Latin locale. I presume a TOC file a zero'd BIN file would compress to a few K, if so attach it to the bug.
Created attachment 53238 [details] zeroed bin file
Created attachment 53239 [details] toc file
Note: to burn these files, you can use "cdrdao write cd.toc". To get a toc and bin, I used "cdrdao read-toc cd.toc" and "dd if=/dev/zero of=data.bin bs=1048576 count=N" where N is greater than or equal to the size of the cd in megabytes.
It's about http://bugzilla.ubuntu.com/show_bug.cgi?id=15220
Created attachment 54018 [details] [review] patch to fix this bug sj-metadata-musicbrainz.c didn't go up one level after descending to the albums[0] level so it was trying to go to albums[0][1] instead of albums[1] on the second album match. Major thanks to ruaok (Robert Kaye) for answering my questions (and starting mb of course).
Thanks! Committed to HEAD and gnome-2-12.
This is broken again for me on sound-juicer-2.13.6 The following CD http://mm.musicbrainz.org/showcdtoc.html?id=147937 is another one that was released twice in two areas, here once in Japan and then later in the US. The same exact DiscID matches both in the MusicBrainz database, as you can see. However, when inserted, sound-juicer prompts me to select which of the two CDs in the database it is-- both of which are the same album, the first listing. (Note that Japanese characters in metadata work perfectly fine in general for other CDs in this series which don't share DiscIDs with US releases.)
It seems like some of the other changes mean that it's not clear what level we're at in the MB data. BUT, MBS_Rewind is for just this purpose. See: http://www.musicbrainz.org/client_howto.html It resets the MB data to the state immediately after the last query. So if we replace the call made by the earlier patch from MBS_Back to MBS_Rewind, it works. I tested on my own machine by patching it myself and it works.
Created attachment 60924 [details] [review] Better patch, using MBS_Rewind This patch fixes it for me.
Cool. I've applied for a freeze break, wish me luck!
Committed to HEAD, thanks.