GNOME Bugzilla – Bug 317748
Update libgtkmozembed-java to compile with JG 2.8/2.12
Last modified: 2009-08-15 18:40:50 UTC
libgtkmozembed-java does not currently compile with CVS head.
Created attachment 52939 [details] [review] Patch to update the configure process. I basically took a look at what Igor did with libvte-java and applied it to this to see if it would work, and it seems to do the trick. We'll probably also need to get the memory managements up to date here.
Thanks for the patch. CC'ing Igor. Would you be able to review this patch (since according to Remy, it emulates the changes you made in libvte-java)?
Remy, very cool that people start converting other Java-GNOME components to 2.8/2.12. :) The patch looks right except the bit about CFLAGS: -libgtkmozembedjni_la_CFLAGS = $(LIBGTKMOZEMBED_CFLAGS) -I$(includedir) $(GTK_CFLAGS) You removd $(GTK_CFLAGS) here for some reason. You should probably leave them there, and you should probably also add $(JG_CFLAGS) there as well (which, now that I look at it, I didn't do in libvte-java either, so I'll add that there). Igor
Created attachment 53038 [details] [review] Updated patch with Igor's suggestions. This patch appends the GTKJAVA and JGJAVA cflags to the libgtkmozembedjni_la_CFLAGS part in Makefile.am in addition to the changes that were originally specified in the first patch for this bug. New additions also includes using a Config.java.in instead of having a MozEmbed.java.in. Source files for Config.java.in and the updated MozEmbed.java are included in the tarball below.
Created attachment 53039 [details] Tarball containing the updated MozEmbed.java file that maps to the generated Config.java from Config.java.in.
Thanks for the patch. Applied to CVS HEAD.