Bug 317732 – Gdm warns incorrectly about caps lock

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 317732 - Gdm warns incorrectly about caps lock


Summary:	Gdm warns incorrectly about caps lock


Status:	RESOLVED FIXED

Product:	gdm
Classification:	Core
Component:	general
Version:	2.8.x
Hardware:	Other Linux

Importance:	Normal normal
Target Milestone:	---
Assigned To:	GDM maintainers
QA Contact:	GDM maintainers

URL:
Whiteboard:

Depends on:
Blocks:

Reported:	2005-10-02 10:55 UTC by Sebastien Bacher
Modified:	2006-03-13 20:41 UTC

See Also:
GNOME target:	---
GNOME version:	2.7/2.8

Attachments
Fix for the problem (1.49 KB, patch) 2005-10-22 14:50 UTC, Michael Hofmann	none	Details \| Review

Description Sebastien Bacher 2005-10-02 10:55:43 UTC

This bug has been opened here: https://bugzilla.ubuntu.com/show_bug.cgi?id=15792

"Gdm warns about caps lock enabled if you use the caps lock indicator (led) to
display the current group when the 
alternative keymap is activated (i.e. the led is enabled).
...
> Thanks for your bug. What caps lock indicator do you use? what do you call
"group"? how do you change your keymap?
...
This is part of my xorg.conf:

Section "InputDevice"
        Identifier      "Generic Keyboard"
        Driver          "keyboard"
        Option          "CoreKeyboard"
        Option          "XkbRules"      "xorg"
        Option          "XkbModel"      "pc105"
--->    Option          "XkbLayout"     "us,us(dvorak):2"
--->    Option          "XkbOptions"    "grp:rwin_toggle,grp_led:caps"
EndSection

The keyboard layout (i.e. group, between basic us and dvorak us) is toggled with
the right win key, the caps led used to show the current group status.

To reproduce, install an alternative layout (with XkbLayout) and use the
XkbOptions line above. Then, when in gdm, press the right win key to switch
groups. When the led is on, i.e. the second group is selected, gdm warns about
activated caps lock."

Comment 1 Brian Cameron 2005-10-06 21:35:58 UTC

I would accept a patch to fix this problem.

Comment 2 Michael Hofmann 2005-10-22 14:50:43 UTC

Created attachment 53764 [details] [review]
Fix for the problem

This patch changes XkbGetIndicatorState calls to XkbGetState with locked
modifiers.

Comment 3 Brian Cameron 2005-10-28 18:57:13 UTC

Accepted, patch in CVS head and 2.8 branch.

Comment 4 Bastien Nocera 2006-03-13 13:01:45 UTC

Quick note to say that the patch is credited to the wrong person in the ChangeLog:

2005-10-28  Brian Cameron  <brian.cameron@sun.com.

        * gui/greeter/greeter_item_capslock.c: Patch to
          make GDM warn correctly about caps lock if an
          alternative keymap is enabled.  Now use
          kbGetState instead of XkbGetIndicatorState.
          Fixes bug #317732.  Patch provided by
          Sebastien Bacher <seb128@debian.org>.

Comment 5 Brian Cameron 2006-03-13 20:41:42 UTC

Thanks, Bastien, corrected in CVS head.