After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 317652 - improve trash applet context menu
improve trash applet context menu
Status: RESOLVED FIXED
Product: gnome-applets
Classification: Other
Component: trash applet
unspecified
Other Linux
: Low enhancement
: ---
Assigned To: gnome-applets Maintainers
gnome-applets Maintainers
Depends on:
Blocks:
 
 
Reported: 2005-09-30 22:23 UTC by Sebastien Bacher
Modified: 2010-01-24 01:07 UTC
See Also:
GNOME target: ---
GNOME version: 2.11/2.12


Attachments
Patch that adds an icon and changes the order (767 bytes, patch)
2006-04-22 11:55 UTC, Manu Cornet
none Details | Review

Description Sebastien Bacher 2005-09-30 22:23:12 UTC
This bug has been opened here: https://bugzilla.ubuntu.com/show_bug.cgi?id=16549

"When right clicking on the trash applet, my purpose most of the time is to empty
it. But the menu is quite cluttered, and I often end up chosing "Remove from
panel", which has a "minus" icon next to it. I think "Empty trash" should be
better highlighted, at least by making the text bold face."
Comment 1 David (djst) Tenser 2006-01-04 11:57:46 UTC
I agree. "Empty Trash" is unquestionably the most used command in that menu, yet it's one of the hardest ones to spot.
Comment 2 Emilian Bold 2006-01-09 22:18:34 UTC
This is the reason I made my bugzilla account.

The trash applet menu is awfull. You have to actively read each time the menu and spot the empty trash item.

Therefore I usually just delete files forever (not move them to trash).

At least you could reduce the menu to something simpler:
 + Empty Trash
 - Advanced -> Remove 
 .................Blah
 .................Blah
Comment 3 Danielle Madeley 2006-01-10 03:42:06 UTC
Those menu items you see below the separator are put there automatically by libpanel-applet. I'm sure there is already a bug pertaining to libpanel-applet and the items it places in the menu, but I can't find it.
Comment 4 David (djst) Tenser 2006-01-10 13:11:16 UTC
(In reply to comment #3)
> Those menu items you see below the separator are put there automatically by
> libpanel-applet. I'm sure there is already a bug pertaining to libpanel-applet
> and the items it places in the menu, but I can't find it.
> 

How come e.g. NetworkManager and gnome-power-manager manage to hide them?
Comment 5 Danielle Madeley 2006-01-10 13:28:42 UTC
Because they are tray icons (ie. they run in the notification area) and not applets. They have a different set of capabilities, and they use an entirely different API. You will notice that the menus, launchers and applets (and even the handle to the left of the notification tray) all have the same three options.
Comment 6 David (djst) Tenser 2006-01-10 20:21:12 UTC
Sorry, I really should have known that by now. :) Thanks for clearing that up, Davyd. 

Anyway, just adding a small empty trash can icon next to the Empty Trash entry would improve things. 

More generally, I think the applet meta menu entries available to all applets should be moved to a submenu labeled "Manage Applet". Except for applets not having its own custom menu entries.
Comment 7 Vincent Untz 2006-01-11 20:49:56 UTC
Submenus are *evil* :-)

So, what's my opinion on this?
We should remove the "lock to panel" (and move to a global lock per panel). I really don't like the submenu idea, so I'm not sure I want to do much more.

Any other sane proposition?
Comment 8 David (djst) Tenser 2006-01-11 21:03:52 UTC
(In reply to comment #7)
> Submenus are *evil* :-)
> 
> So, what's my opinion on this?
> We should remove the "lock to panel" (and move to a global lock per panel). I
> really don't like the submenu idea, so I'm not sure I want to do much more.

To reiterate, adding an icon next to the Empty Trash menu item, and perhaps moving it to the top would help too.

> 
> Any other sane proposition?

Sorry for being insane. I don't like submenus either, since they're hard to click on. I don't really like right-click menus in the first place. How about adding a left-click menu then? Or is that non-standard in Gnome? What I mean is a menu specifically for the trash can, with only Empty Trash and Open. Not my favorite solution, just brainstorming here..

Comment 9 Vincent Untz 2006-01-11 21:07:21 UTC
(note that I was not saying you're insane ;-))
Comment 10 Manu Cornet 2006-04-22 11:55:35 UTC
Created attachment 64099 [details] [review]
Patch that adds an icon and changes the order

Ok guys, here's a patch that 1) adds a "gtk-clear" icon (the broomstick) next to the "Empty Trash" entry and 2) places it before "Open".

Another argument in favor of this is that when you want to open the trash, you usually just left-click on it.
Comment 11 Vincent Untz 2006-08-08 18:52:46 UTC
Ok, this is a trash applet bug in fact.
Comment 12 Danielle Madeley 2006-11-16 12:35:35 UTC
Empty trash doesn't have an icon in Nautilus, should we be consistent here?
Comment 13 Daniel Holbach 2007-05-24 13:33:17 UTC
That'd be nice.
Comment 14 Allison Karlitskaya (desrt) 2008-12-22 18:59:06 UTC
I just did a little bit of poking around.

This holds for almost everywhere else that has both a left-click (or left-double-click) action and a context menu together: the first item on the context menu is the same as the result of left (double-)clicking.

I guess this principle should not be violated.
Comment 15 Allison Karlitskaya (desrt) 2009-01-30 23:01:45 UTC
2009-01-29  Ryan Lortie  <desrt@desrt.ca>

        * GNOME_Panel_TrashApplet.xml: change "Open" to "Open Trash" (for
        consistency) and add an icon to the "Empty Trash" menu item.

Committed revision 11232.