After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 317630 - cdparanoia seems to read one sector too much
cdparanoia seems to read one sector too much
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins
0.8.10
Other Linux
: Normal normal
: 0.8.12
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2005-09-30 18:22 UTC by Loïc Minier
Modified: 2005-09-30 21:33 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
don't play the last segment (397 bytes, patch)
2005-09-30 18:22 UTC, Loïc Minier 		committed Details | Review

Description Loïc Minier 2005-09-30 18:22:03 UTC 
Hi,

Gustavo Noronha Silva reported in Debian bug http://bugs.debian.org/330954 that
gnome-cd locks at the end of the last track when using cdparanoia.

He proposes the following patch fixing the issue for him:
--- ext/cdparanoia/gstcdparanoia.c~     2005-08-29 11:50:49.000000000 +0000
+++ ext/cdparanoia/gstcdparanoia.c      2005-09-30 15:53:19.155742291 +0000
@@ -553,7 +553,7 @@
   }
 
   /* stop things apropriatly */
-  if (src->cur_sector > src->segment_end_sector) {
+  if (src->cur_sector >= src->segment_end_sector) {
     GST_DEBUG ("setting EOS");
 
     buf = GST_BUFFER (gst_event_new (GST_EVENT_EOS));

I'm going to attach his diff as a real file.

Cheers,
Comment 1 Loïc Minier 2005-09-30 18:22:46 UTC 
Created attachment 52876 [details] [review]
don't play the last segment
Comment 2 Tim-Philipp Müller 2005-09-30 21:33:00 UTC 
Problem and fix verified and committed to CVS/0.8 branch:

2005-09-30  Gustavo Noronha Silva  <kov at debian dot org>

       Reviewed by: Tim-Philipp Muller  <tim at centricular dot net>

       * ext/cdparanoia/gstcdparanoia.c: (cdparanoia_get):
         Fix EOS detection for last title (fixes gnome-cd hanging
         after last track ends) (#317630).

Thanks a lot for the patch!

Cheers
 -Tim