After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 317585 - eject/disconnect/unmount/remove volum entry in "File" menu
eject/disconnect/unmount/remove volum entry in "File" menu
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: File and Folder Operations
2.13.x
Other All
: Normal minor
: 2.16.x
Assigned To: Christian Neumair
Nautilus Maintainers
: 148121 329909 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2005-09-30 09:46 UTC by Łukasz Stelmach
Modified: 2006-05-26 15:56 UTC
See Also:
GNOME target: ---
GNOME version: 2.15/2.16


Attachments
Proposed prelimitary patch (11.40 KB, patch)
2006-02-05 13:12 UTC, Christian Neumair
rejected Details | Review
Patch that was approved for 2.15 (15.32 KB, patch)
2006-02-25 21:13 UTC, Christian Neumair
committed Details | Review

Description Łukasz Stelmach 2005-09-30 09:46:42 UTC
To add the "Eject Volume" action to the "File" menu if the user is currently
browsing unmountable/ejectable medium. Just like choosing "Eject Volume" from
the popped up menu of the volume icon.

The same way one is able to emptry the trash bin.

Other information:
Comment 1 Murray Cumming 2005-12-02 15:45:36 UTC
Me too. Without this, if there is no icon on the desktop (as in Ubuntu) then the
user must go to Places/Computer and right click on the CD there. That's hard to
find.
Comment 2 Fabio Bonelli 2006-02-05 10:27:22 UTC
*** Bug 329909 has been marked as a duplicate of this bug. ***
Comment 3 Fabio Bonelli 2006-02-05 10:32:12 UTC
*** Bug 148121 has been marked as a duplicate of this bug. ***
Comment 4 Fabio Bonelli 2006-02-05 10:35:49 UTC
From bug 148121, Vincent Noel suggests a workaround:

"You can also use the Shift-F10 keyboard shortcut."

Marking duplicate the older bug because this has a more general description.
Comment 5 Christian Neumair 2006-02-05 13:12:10 UTC
Created attachment 58759 [details] [review]
Proposed prelimitary patch

This superficially tested patch was also submitted to nautilus-list for review:
http://mail.gnome.org/archives/nautilus-list/2006-February/msg00005.html
Comment 6 Christian Neumair 2006-02-25 21:11:46 UTC
Missed 2.14 feature freeze, milestoning to 2.16 since another followup patch available on the list was approved.
Comment 7 Christian Neumair 2006-02-25 21:13:39 UTC
Created attachment 60127 [details] [review]
Patch that was approved for 2.15
Comment 8 Kjartan Maraas 2006-05-09 10:49:16 UTC
Maybe this should go in now?
Comment 9 Martin Wehner 2006-05-26 15:56:23 UTC
It's in already:

2006-04-27  Christian Neumair  <chris@gnome-de.org>

	* src/file-manager/fm-actions.h:
	* src/file-manager/fm-directory-view.c:
	(file_get_volume_and_drive),
	(action_self_mount_volume_callback),
	(action_self_unmount_volume_callback),
	(action_self_eject_volume_callback),
	(action_self_format_volume_callback),
	(file_get_volume_and_drive),
	(file_should_show_self),
	(real_update_menus_volumes):
	* src/file-manager/fm-tree-view.c:
	(create_popup_menu):
	* src/file-manager/nautilus-directory-view-ui.xml:
	Allow to mount/unmout/eject/format a volume when displaying its
	activation URI.