GNOME Bugzilla – Bug 317537
seahorse-key-properties usability redo
Last modified: 2005-12-29 16:33:31 UTC
Distribution/Version: Ubuntu Breezy This is basically the seahorse-key-properties usability redo that I have been working on. Its not golden yet, but its mostly there. Things left to confirm/fix 1. The remote key checking is no longer necessary because if the key is private most everything is disabled anyways. Is this correct? 2. I took out the utf-8 stuff, sounds like something that should get checked before it even makes it to the gui. Maybe should go somewhere in lib. 3. Adam's photoid stuff!!! 4. Can't open the same key twice!!! 5. Keys in the maintabs become reodered, sometimes shoved to the bottom, or jump to the top. 6. Singing uids is broken, its broken in HEAD as well. 7. In HEAD the signature tabs the revoke and delete buttons are always disabled. Need to find a way to get these working again. 8. Hiden publishing key tab, its just an idea, but needs to implemented. This can be applied by simply dropping the files in as replacements. Test it out, make suggestions, especailly for the photoid interface.
Created attachment 52816 [details] key-properties usability redo
Created attachment 52817 [details] key-properties usability redo glade file
Things left to confirm/fix 1. I meant to say if the key is ->PUBLIC<- most everything is disabled.
Adam's photoid stuff is in the patch now. I didn't really have to do too much beyond copy and paste. I think this patch is ready to go. We need to get it in HEAD if we can.
Created attachment 53248 [details] key-properties usability redo c file
Created attachment 53249 [details] key-properties usability redo glade file
Created attachment 53250 [details] seahorse-person.png I needed to make the canvas on the image a bit larger so it filled up some space.
I'm not sure I like the photo id frame resizing with different size photos. Try testing with 1 pixel ids and regular size ids to see how annoying it is. The resizing with the expanders looks good. On the signatures tab, the view signatures on uid combo box shouldn't say everybody. There should probably be a label next to the combo box saying "Filter Signatures By User ID" <combobox> all, uid1, uid2, etc</combobox>. For proper photo id handling, the patches attached to bugs #315084 and #314744 need to be applied. I'm leaning towards commiting them to cvs.
I fixed the signal problem by moving them to their own functions. I also fixed the Everybody in the combobox. As far as the frame resizing, I'm not finding a way to do it. I agree that the 1 pixel thing should get handled better, but lets put that stuff in later down the road with all together better image handling such as modifying, cropping, scrolling, etc..
Created attachment 53344 [details] Seahorse-key-properties.c
Created attachment 53345 [details] Seahorse-key-properties.glade
Created attachment 53346 [details] Seahorse-key-properties.c
Created attachment 53347 [details] Seahorse-key-properties.c
Created attachment 53348 [details] Seahorse-key-properties.c
I've committed Jim's code. A few notes: * Its easier to work with patches rather than full files, even for files that are heavily modified. It helps guarantee that we're not accidentally stomping on each others changes. * Although this is committed it could still use more work. I'm willing to put some in: * Public keys should have a simpler properties dialog without all the periphery needed for public keys. * Photo next and delete (only when multiple photos are present) * Photo remove (only when one or more photos are present) * "User Id" -> "Other Names" (or something like that) * Photo centered on a big black background, and enlarged to largest proportional fit, keeping a small border of black. I'll try my hand at this. * Trust is something we should feature prominently for public keys, and basically hide for private keys. * Disable 'User ID' buttons that don't do anything (ie: when no user id is selected. Ditto for signatures. Let's attach patches to this bug.
2005-10-13 Nate Nielsen <nielsen@memberwebs.com> * libseahorse/seahorse-key.h: * libseahorse/seahorse-pgp-key.c: * libseahorse/seahorse-pgp-key.h: * src/Makefile.am: * src/seahorse-key-properties.c: * src/seahorse-key-properties.glade: * src/seahorse-pgp-public-key-properties.glade: Added a simpler properties interface for public keys. (bug #317537)
That looks really good. However when viewing "others that trust this key" either the dialog needs to be made resizable or the columns in the tree view do. Also, on the trust tab of the public key properties, you've confused trust and validity. Validity indicates you believe the key to belong to the person it says it does and marking validity is accomplished by signing a key/uids. Trust is a measure of how well you think the person verifies identities before signing a key. Thus you can sign a key with ultimate validity while not trusting any signatures the person makes.
2005-10-13 Nate Nielsen <nielsen@memberwebs.com> * src/seahorse-key-properties.c: Wholesle fixing of memory leaks, translations problems, compilation warnings etc...
> However when viewing "others that trust this key" > either the dialog needs to be made resizable or > the columns in the tree view do. True. It's all of our code. You probably know best how to change it as you can see in your head what it should be like. On 'Trust' and 'Validity'. I've confused them on purpose. We want to present a simple concept to users. This concept also extends into X.509 keys, SSH keys etc. so it needs to be generic. Perhaps a better term is needed. Any ideas?
Incorporated Adam's text clarifications and ideas, hid unnecessary photo buttons: 2005-10-13 Nate Nielsen <nielsen@memberwebs.com> * src/seahorse-key-properties.c: * src/seahorse-pgp-public-key-properties.c: More UI tweaking
Created attachment 53492 [details] [review] Activates ability to set a photo as primary This patch is rather trivial and allows the user to make a photo id primary. I'll try and take a look at that first button later.
Created attachment 53493 [details] [review] GPG patch for photo reordering For proper reordering of photo ids after setting one primary, you will need this patch from David Shaw against keylist.c in gnupg-1.4.2. He has said that it will be included in future stable releases.
Created attachment 53498 [details] [review] First Photo Button Implementation This patch adds the first photo button functionality.
Created attachment 53549 [details] [review] Combines the first two patches and adds a last button
Do we really want 'first' and 'last' buttons? Doesn't it start to get a bit overwhelming?
I was thinking of modifying the show code to only show them if there were more than 2 photo ids instead of whenever there were photo ids so they'd only be there hen they'd add extra functionality over the next and previous buttons.
Created attachment 54145 [details] [review] Combo Patch This patch has the same functionality as the last one, but the first and last buttons are only visible when more than 2 photoids are present i.e. when they add functionality instead of duplicating it.
Created attachment 55596 [details] [review] Enables scrolling photo IDs I'm committing this, but wanted to let people know how it was done.
I'm closing this bug but breaking out seperate but similar issues as enhancement requests.