GNOME Bugzilla – Bug 317507
Mute key popup is odd
Last modified: 2007-08-18 12:41:08 UTC
This bug has been opened here: https://bugzilla.ubuntu.com/show_bug.cgi?id=14062 "When the very nice mute key popup comes up, on mute it shows the volume level and that is a muting. I think it should lower the volume bar to zero as well. When it is unmuted, the volume bar should return to its previous state. This is consistent with the activity on OSX. .... Confirmed; I'd expect to see a big red circle-with-line over the speaker, rather than just "no notes"? "
Marking as NEW.
Created attachment 52840 [details] [review] patch to set the volume to zero when the channel is muted. Making the range widget drop to zero when the volume is muted doesn't really show what's going on. There is a mute flag that is set on the channel, but the volume stays at the same level whether or not the mute flag is set. If you want to see what I mean, open the gnome-volume-control capplet and mute the volume using mixer_applet2. The volume isn't actually set to zero, but the channel is muted. It's not intuitive to the user perhaps, but it actually reflects what is being done. To actually implement this you need to mute the channel _and_ set the volume on the channel to zero. I don't know if this is really a good idea. That being said here is a simple patch to do this. It is wrong in its handling of the volume when the applet is started when the channel is muted. Unmuting the channel will result in the volume still being zero since the saved_volume is initialized to zero in the object init function. You would need to check whether the channel is muted on startup and set the saved_volume to something appropriate to make it work somewhat sanely.
I guess the original complaint was against the gnome-volume-control capplet and not the dock applet. Oops. The complaint is valid for the dock applet too.
Created attachment 61923 [details] [review] a patch to use stock icons from the current theme attached patch replaces the osd images with images from the current theme, that way they are also in sync with i.e. the mixer applet. it also adds steps like the mixer applet to the volume icons.
Created attachment 63333 [details] [review] patch from the Ubuntu package That's the patch I used for the Ubuntu package. The previous version uses icons specific to the tango theme. Note that the gnome theme icons choice could be better, it looks weird at the moment with the gnome theme
control-center folks, can this please get in?
As mentioned in comment #3, the first patch is for the volume applet, not the OSD in the settings daemon. It needs to be moved to the gnome-applets product. The patch from Ubuntu looks good, and I will commit it after testing.
The control-center patch does not apply cleanly to SVN trunk, we need another updated patch
I don't think setting the volume bar to 0 on mute is a good idea. See bug 337896 for some rationale why it can be useful to actually see the volume level one would get when unmuting. My vote goes to WONTFIX.
Jens, I understand your rationale; however as Thomas says above, it's still useful to have a proper icon for the mute popup. Part of the bug was about that being confusing. If you see the downstream bug - https://bugs.launchpad.net/ubuntu/+source/control-center/+bug/20302 - you'll see the patch which Ubuntu has applied which gives a clear mute icon.
(In reply to comment #10) > Jens, I understand your rationale; however as Thomas says above, it's still > useful to have a proper icon for the mute popup. Part of the bug was about that > being confusing. I honestly don't understand what is confusing about the current mute icon. Maybe it was different in 2.14? Otherwise, please explain.
I don't know what the current mute icon is; because I only see Ubuntu and Ubuntu has committed that patch. The non-confusing one has a red symbol on it.
Created attachment 93896 [details] muted This is the current mute icon, and I'd be a bit surprised if Ubuntu still had that patch applied since it doesn't apply against trunk, and this bug has been open for a long time, waiting for an updated patch.
That looks perfectly clear, thank you.