After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 317336 - Arabic characters are not connected when use plain True Type fonts.
Arabic characters are not connected when use plain True Type fonts.
Status: RESOLVED FIXED
Product: pango
Classification: Platform
Component: general
unspecified
Other All
: Normal normal
: Medium fix
Assigned To: pango-maint
pango-maint
Depends on:
Blocks:
 
 
Reported: 2005-09-27 11:59 UTC by Takao Fujiwara
Modified: 2012-08-18 17:50 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Snapshot for the original pango (12.18 KB, image/png)
2005-09-27 12:00 UTC, Takao Fujiwara 		  Details
Snapshot for the patched pango (12.01 KB, image/png)
2005-09-27 12:00 UTC, Takao Fujiwara 		  Details
Patch for ArabicShaping (10.90 KB, patch)
2005-09-27 12:01 UTC, Takao Fujiwara 		rejected Details | Review

Description Takao Fujiwara 2005-09-27 11:59:05 UTC 
When we use plain True Type fonts, Arabic characters are not connected.

Open Type + pango works very fine but our default font is the plain True Type font.
I'm attaching two snapshots. One is the original rendering and another is the
new patch.

I'm attaching the patch. Could you help the patch? Actually I ported the code of
mozilla but when I tested the patch, I found pango specific crash issues.
It means Mozilla fixes this problem.

The patch converts U+06xx chars to U+FExx chars.
Comment 1 Takao Fujiwara 2005-09-27 12:00:04 UTC 
Created attachment 52720 [details]
Snapshot for the original pango
Comment 2 Takao Fujiwara 2005-09-27 12:00:43 UTC 
Created attachment 52721 [details]
Snapshot for the patched pango
Comment 3 Takao Fujiwara 2005-09-27 12:01:45 UTC 
Created attachment 52723 [details] [review]
Patch for ArabicShaping

Attached the patch.
Comment 4 Behdad Esfahbod 2005-09-27 23:43:53 UTC 
Thanks Takao.  I like to see Pango doing shaping to presentation forms again. 
On Fedora Core 4 default install it picks up bitmap fonts for Persian, and Pango
doesn't shape.

The patch doesn't look that good to me.  It's duplicating the joining logic we
already have in the Arabic module.  I think I'll hack up a patch myself in time
for the next major release, but feel free to ping or discuss furhter.

I don't exactly remember, but I think we had code in Pango to do that
previously. Will check that later.

Random note of the day:
Owen: What do you think about maintaining separate ChangeLog's for modules?
Comment 5 Owen Taylor 2005-09-28 03:54:36 UTC 
I dislike separate changelogs quite a bit. They are a huge pain when
you have to make a change spanning several changelogs, and also make collecting
information for updating NEWS files a lot harder.

(In thae end we really need to figure out how to sort real 
Arabic fonts first for the Arabic script, probably using the recently used
fontconfig support for :capability=otlayout:arab, though that's not terribly
easy...)
Comment 6 Behdad Esfahbod 2012-08-18 17:50:44 UTC 
Fixed in HarfBuzz, and we just merged the harfbuzz branch in.