After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 317300 - inline functions should be static or extern
inline functions should be static or extern
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins
0.8.x
Other opensolaris
: Normal normal
: 0.8.12
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2005-09-26 23:04 UTC by Brian Cameron
Modified: 2005-10-19 10:57 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch to properly define inline functions (3.90 KB, patch)
2005-09-26 23:04 UTC, Brian Cameron
committed Details | Review

Description Brian Cameron 2005-09-26 23:04:01 UTC
Attaching a patch that makes inline functions that are really static function
defined as static and those that are extern defined as extern.  The forte
compiler does not compile inline functions as inline unless they are defined as
"static inline" or "extern inline".
Comment 1 Brian Cameron 2005-09-26 23:04:34 UTC
Created attachment 52709 [details] [review]
patch to properly define inline functions
Comment 2 Tim-Philipp Müller 2005-10-19 10:57:55 UTC
Committed to 0.8 branch (and goom in gst-plugins-good HEAD, the rest will start
from the 0.8 version when ported to 0.9):

2005-10-19  Brian Cameron  <brian dot cameron at sun dot com>

        * ext/smoothwave/gstsmoothwave.c:
        * gst-libs/gst/resample/resample.c:
        * gst/dvdsubdec/dvdsubdec.c:
        * gst/goom/filters.c:
        * gst/goom/graphic.h:
        * gst/goom/lines.c:
        * gst/mpeg2sub/gstmpeg2subt.c:
          Make inline functions either 'static inline' or 'extern inline',
          otherwise the Forte compiler apparently won't inline them (#317300).

Cheers
 -Tim