GNOME Bugzilla – Bug 317192
Update mini-fribidi
Last modified: 2005-11-03 21:14:10 UTC
I'm attaching patches to update pango/mini-fribidi to latest version of GNU FriBidi (0.10.7). There's not much difference code-wise, except for the memory chunk stuff that Noah had ripped off previously, but this cleans up a lot of other mess too. I moved pango_unichar_direction and pango_log2vis_get_embedding_levels back to pango-utils.c, and simplified the fribidi patch a lot, by using fribidi_config.h to instruct it how to behave. The fribidi.patch is mostly all lines being removed from fribidi sources, not adding new lines. This makes maintenance of that directory far easier. As a bonus, Pango can be compiled using system FriBidi again. Just pass --with-fribidi to configure. It doesn't try to pick it up by default though. Owen, Noah, review please.
Created attachment 52645 [details] [review] patch against HEAD, without the mini-fribidi directory. This patches the rest of Pango for this change, and is enough to get Pango going with --with-fribidi.
Created attachment 52646 [details] pango/mini-fribidi tarball And this is the new pango/mini-fribidi tarball. I made a tarball instead of patch, to make review easier.
Depending on bug 118439 for the new glib chunk allocator, to use for allocating FriBidi TypeLink's.
Humm, in a second thought, we are maintaining our own trash stack on top of GMemChunk. So it's not absolutely necessary to use new glib allocator. We may want to use GTrashStack though.
Created attachment 54287 [details] [review] new patch with utf8 support. This patch includes all the bits, no tarball needed. This also has UTF8 support added to fribidi, so no utf8->ucs4 conversion anymore!
Committed after removing the --with-fribidi stuff. 2005-11-03 Behdad Esfahbod <behdad@gnome.org> * docs/tmpl/main.sgml, pango/Makefile.am, pango/pango-context.c (itemize_state_init), pango/pango-utils.c, pango/pango-utils.h, pango/pangox.c (itemize_string_foreach), pango/mini-fribidi/*: Updated to FriBidi version 0.10.7 patched to handle UTF-8 directly. Moved pango_log2vis_get_embedding_levels to pango-utils.c instead of mini-fribidi. (#317192, review by Matthias Clasen)