After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 316925 - Export presence over Galago
Export presence over Galago
Status: RESOLVED FIXED
Product: gossip
Classification: Deprecated
Component: General
0.9
Other Linux
: Normal normal
: ---
Assigned To: Gossip Maintainers
Gossip Maintainers
Depends on: 316917
Blocks:
 
 
Reported: 2005-09-22 10:55 UTC by Ross Burton
Modified: 2005-11-01 19:13 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
First draft (9.20 KB, patch)
2005-09-22 10:56 UTC, Ross Burton
none Details | Review
Second draft (9.33 KB, patch)
2005-09-22 15:58 UTC, Ross Burton
none Details | Review
Third draft (14.12 KB, patch)
2005-10-09 18:00 UTC, Martyn Russell
none Details | Review
Forth draft (15.16 KB, patch)
2005-10-10 08:48 UTC, Ross Burton
none Details | Review

Description Ross Burton 2005-09-22 10:55:49 UTC
Attaching a prototype patch to export presence over Galago.  It needs more work
but sort-of works.
Comment 1 Ross Burton 2005-09-22 10:56:33 UTC
Created attachment 52499 [details] [review]
First draft
Comment 2 Ross Burton 2005-09-22 15:58:47 UTC
Created attachment 52513 [details] [review]
Second draft
Comment 3 Mikael Hallendal 2005-10-09 11:55:08 UTC
Hmm, could you use the coding style that Gossip use, would make looking at the
patch a lot easier.

It would also be nice to have the Galago support optional.
Comment 4 Martyn Russell 2005-10-09 18:00:48 UTC
Created attachment 53256 [details] [review]
Third draft

OK, I had a quick butchers at this and fixed the coding style which as Micke
says would have made things a lot quicker for me.

I have also fixed up some unnecessary warnings and added a load of debugging to
know what is happening.

I know very little about Galago at the moment, and apart from seeing it talk to
libgalago OK I couldn't see how the information we pass on is being used - what
application can I use to do this?  I did look at dbus-viewer to see something
that resembled my contact list, but would like something better
(gnome-presence-applet?).

Current issues for me:
- I didn't get around to making libgalago an optional component yet (in
configure), that is essential.
- I wasn't sure if Galago expects the "contact-removed" signal to mean actually
removed from the roster permanently or the same meaning we have (i.e. remove
temporarily like when you go online/offline).
- There are some issues when the session presence changes and it looks up the
account to use with Galago.  With my environment I have 6 accounts (mostly for
testing) and it doesn't work so well in some situations.  I get the "Cannot
find account" error, but, that might be a gossip-session thing, I need to look
at this further when I have time.

Apart from all that, it looks like a good start, thanks Ross, looking forward
to the next patch ;)
Comment 5 Ross Burton 2005-10-10 08:17:49 UTC
For basic debugging I use get-presence from libgalago/tests, for real-world use
I am using a Secret Application.  I'll work on some of the remaining problems today.
Comment 6 Ross Burton 2005-10-10 08:48:50 UTC
Created attachment 53279 [details] [review]
Forth draft

This patch makes Galago conditional.
Comment 7 Martyn Russell 2005-11-01 19:13:54 UTC
OK Ross, I have now committed this since it works with the get-presence test app
that comes with libgalago.

It needs some work in places but it is a start.

Thanks for the patch ;)