After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 316618 - import ACO (Adobe COlor) palette files
import ACO (Adobe COlor) palette files
Status: RESOLVED FIXED
Product: GIMP
Classification: Other
Component: General
unspecified
Other All
: Normal enhancement
: 2.4
Assigned To: GIMP Bugs
GIMP Bugs
Depends on:
Blocks:
 
 
Reported: 2005-09-18 11:52 UTC by Sven Neumann
Modified: 2007-08-07 13:44 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Script-fu to load ACO files (8.24 KB, text/plain)
2006-03-05 05:41 UTC, saulgoode
  Details
Corrected version (8.50 KB, text/plain)
2006-03-05 05:51 UTC, saulgoode
  Details
Patch to add ACO and CSS importing to palette import function (8.85 KB, patch)
2007-08-05 20:12 UTC, Nicola Archibald
committed Details | Review

Description Sven Neumann 2005-09-18 11:52:25 UTC
There's some reverse-engineered information available. Someone might want to
look into adding support for reading this format to the GIMP Palette importer.
Comment 2 saulgoode 2006-03-05 05:41:54 UTC
Created attachment 60680 [details]
Script-fu to load ACO files

I know this isn't what you had in mind but I *needed* an interpreted language for interactive debugging. The script seems to work for the samples that I found (I don't have PS). I have included some code to handle HSB, LAB, and CMYK palettes but have not tested them (and doubt that it works). I intend to spend some time on these colorspaces as soon as I find some samples. I suppose there are some library functions in the GIMP that do those conversions but they are not exposed to SIOD (I want to learn more about this aspect of colorspaces anyway).

I wouldn't want my activities to discourage anyone from working on this report; I am just noodling and thought I would share.
Comment 3 saulgoode 2006-03-05 05:51:23 UTC
Created attachment 60681 [details]
Corrected version

I screwed up (again) and attached the wrong file. This version correctly defines some functions *internal* to the script instead of globally. I am terribly sorry.
Comment 4 Sven Neumann 2006-03-07 07:26:14 UTC
This functionality should be added to app/core/gimppalette-import.c. It doesn't make sense to import four palette formats there and then implement the fifth in a script.
Comment 5 Nicola Archibald 2007-08-05 20:12:57 UTC
Created attachment 93117 [details] [review]
Patch to add ACO and CSS importing to palette import function

The attached patch implements version 1 ACO importing, and importing colors defined in CSS files, to the 'Import Palette' function.
Comment 6 Sven Neumann 2007-08-07 13:44:09 UTC
I have applied the part of the patch that deals with ACO files. It is somewhat unfortunate that the CSS import is part of the same patch. It can however not be applied as it uses functionality from GLib 2.14. Nicola, can you please redo the CSS part of the patch against SVN and open a new bug report for it? We will then look at it again as soon as we have branched for GIMP 2.6 and depend on a newer version of GLib.

2007-08-07  Sven Neumann  <sven@gimp.org>

	* app/core/gimppalette-import.c
	* app/core/gimppalette-load.[ch]: applied slightly modified version
	of a patch from Nicola Archibald that adds support for importing
	Adobe Color palette version 1 files (bug #316618).