GNOME Bugzilla – Bug 316361
Quit / New Game consistency
Last modified: 2012-11-14 01:23:35 UTC
This bug is here to track the games which don't offer a Quit / New Game with their end-of-game dialogs. This includes high scores dialogs which may not always appear. The list is: Five or More Mahjongg Gnometris Nibbles Robots Tetravex Klotski? (This is a candiadate for different behaviour due to its natural progression) Games which don't have definite end-game states, but could be extended: Tali
Oops, forgot gnome-stonesThe list is: Five or More Mahjongg Gnometris Nibbles Robots Tetravex Stones Klotski? (This is a candiadate for different behaviour due to its natural progression) Games which don't have definite end-game states, but could be extended: Tal
Created attachment 79086 [details] [review] add Quit / New Game to gnotravex This does three things: 1) Adds Quit / New Game to gnotravex. 2) Fixes an issue with not setting the high score category on the first game. 3) A small clean up to remove a few lines left when moving to the new high score code. The issue in #2 will result in not being added to the high score before a new size has been selected in the menu. You might want to include the fix for #2 and perhaps #3 in 2.17. If you want a separate patch for these let me know.
it looks like Robert Ancell picked up the fix for #2 in http://bugzilla.gnome.org/show_bug.cgi?id=391216 so thats fixed now. Great!. I had an extra line in there to always save the board size to gconf at game start too. This was simply to save the board size if it had been given as a command line option. I'm not even sure it's the correct thing to do and it's definitely not very important so I'll just drop that from the updated patch. I'll open a new bug for the clean up stuff too to get that in 2.17. This should make this patch focused on just the Quit / New game stuff
Created attachment 79091 [details] [review] add Quit / New Game to gnotravex v2
Patch from Thomas applied to SVN. The updated list is now: Five or More Mahjongg Gnometris Nibbles Robots Stones Klotski? (This is a candiadate for different behaviour due to its natural progression) Games which don't have definite end-game states, but could be extended: Tali
Re-assigning to new default owner.
The Quit/New Game dialog in Tetravex (Gnome 2.24, Ubuntu 8.10) is broken. When you click New Game, it immediately redisplays the high score dialog and adds a duplicate of the last high score entry to the table, then drops back to the Quit/New Game dialog.
#7 That has been fixed and released in 2.24.1.1. You should get the fix when ubuntu updates to the new version. Feel free to ask them to do so. Thanks for taking the time to file this bug anyway.
Seems very old, but please re-open against each module if still applicable.