After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 316329 - Right-click context menu
Right-click context menu
Status: RESOLVED FIXED
Product: evince
Classification: Core
Component: general
git master
Other Linux
: Normal enhancement
: ---
Assigned To: Evince Maintainers
Evince Maintainers
: 318314 (view as bug list)
Depends on:
Blocks: 325047
 
 
Reported: 2005-09-14 18:46 UTC by Christian Persch
Modified: 2005-12-25 20:09 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch (14.78 KB, patch)
2005-10-12 11:50 UTC, Carlos Garcia Campos
none Details | Review

Description Christian Persch 2005-09-14 18:46:21 UTC
Evince should have a context menu with "Copy" when right clicking on selected
text; and "Copy Image", "Save Image As" when right-clicking on an image.
Comment 1 Sergej Kotliar 2005-09-18 12:01:55 UTC
Perhaps zooming could be in there too.
Don't know how realistic image copying is, but copying text should be possible
Comment 2 Carlos Garcia Campos 2005-09-27 11:05:39 UTC
I think there are other possible actions that could be included in the context
menu. 
I propose a simple menu like this:

<popup name="ViewPopup">
     <menuitem name="ViewPreviousPagePopup" action="GoPreviousPage"/>
     <menuitem name="ViewNextPagePopup" action="GoNextPage"/>
     <menuitem name="ViewReloadPopup" action="ViewReload"/>
     <separator/>
     <menuitem name="ViewCopyPopup" action="EditCopy"/>
     <separator/>
     <menuitem name="ViewSelectAllPopup" action="EditSelectAll"/>
</popup>

ViewCopyPopup would be visible only if there is text selected and
ViewSelectAllPopup when the document allow selections
Comment 3 Carlos Garcia Campos 2005-09-28 12:43:34 UTC
I think there is yet another useful use of the context menu. For external links
it  could show "Open Link" and "Copy Link Address"
Comment 4 Nickolay V. Shmyrev 2005-10-09 10:03:54 UTC
*** Bug 318314 has been marked as a duplicate of this bug. ***
Comment 5 Jones Lee 2005-10-11 03:12:50 UTC
I propose that 2 types of context menu. One for the text selection and other 
for general view of the pdf. Currently, evinice does not differentiate between 
normal view mode and text selection mode like Adobe Acrobat Reader. So for now, 
we can work on the text selection context menu like this:

<popup name="SelectPopup">
     <menuitem name="Copy" action="CopyToClipboard"/>
     <separator/>
     <menuitem name="SelectAll" action="SelectAll"/>
     <menuitem name="DeSelectAll" action="DeSelectAll"/>
</popup>
Comment 6 Carlos Garcia Campos 2005-10-12 11:50:09 UTC
Created attachment 53365 [details] [review]
Patch

Ok, here is my proposal. At this moment there are two menus: DocumentPopup and
ExternalLinkPopup

<popup name="DocumentPopup" action="PopupAction">
    <menuitem name="GoPreviousPageDP" action="GoPreviousPage"/>
    <menuitem name="GoNextPageDP" action="GoNextPage"/>
    <menuitem name="ViewReloadDP" action="ViewReload"/>
    <separator/>
    <menuitem name="EditCopyDP" action="EditCopy"/>
    <menuitem name="EditSelectAllPopup" action="EditSelectAll"/>
</popup>

<popup name="ExternalLinkPopup" action="PopupAction">
    <menuitem name="OpenLinkELP" action="OpenLink"/>
    <menuitem name="EditCopyELP" action="EditCopy"/>
    <menuitem name="CopyLinkAddressELP" action="CopyLinkAddress"/>
</popup>

In both Document and ExternalLink, copy action will only be visible when there
is text selected. I'm not sure if "Select all" should be invisible when
selection is not supported by the document.
Comment 7 Jones Lee 2005-10-13 04:00:11 UTC
What about "DeSelectAll"? I find "DeSelectAll" is quite handy and useful.
Comment 8 Carlos Garcia Campos 2005-10-13 08:34:37 UTC
You can DeSelectAll by simply clicking on the view which is faster than right
click -> DeSelectAll. I think the context menu should be as simple as possible. 
Comment 9 Nickolay V. Shmyrev 2005-12-25 20:09:50 UTC
Patch is applied. I've modified it a bit to hide view details from window and to make memory management more clear, but thanks a lot anyhow.

I think any suggestions about menu contents should be discussed in other bugs.