After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 316005 - Add text shadows for better contrast
Add text shadows for better contrast
Status: RESOLVED WONTFIX
Product: vte
Classification: Core
Component: general
0.11.x
Other All
: Normal enhancement
: ---
Assigned To: Chris Wilson
VTE Maintainers
[wontfix-next]
Depends on:
Blocks:
 
 
Reported: 2005-09-11 17:12 UTC by Marius Gedminas
Modified: 2015-12-26 12:34 UTC
See Also:
GNOME target: ---
GNOME version: Unversioned Enhancement


Attachments
Experimental patch to demonstrate drop shadows (incomplete!) (1.57 KB, patch)
2006-04-16 20:24 UTC, Marius Gedminas
none Details | Review
Screenshot with the patch applied (123.46 KB, image/png)
2006-04-16 20:25 UTC, Marius Gedminas
  Details
Screenshot without the patch (104.58 KB, image/png)
2006-04-16 20:26 UTC, Marius Gedminas
  Details
Updated dropshadow patch. (4.68 KB, patch)
2007-01-26 22:24 UTC, Chris Wilson
needs-work Details | Review

Description Marius Gedminas 2005-09-11 17:12:35 UTC
When you use a terminal with a translucent background, it becomes difficult to
read text.  Eterm can draw shadow effects that improve readability a lot in this
case.  I think this would be useful for GNOME Terminal as well.

I've written a small patch for the Xft2 backend to try this out, and made a
screenshot: http://mg.pov.lt/blog/gnome-terminal-text-effects.html
Comment 1 Behdad Esfahbod 2006-04-12 06:54:35 UTC
Please attach screen shot and patch here.  I cannot access that page at this time.
Comment 2 Marius Gedminas 2006-04-16 20:24:22 UTC
Created attachment 63659 [details] [review]
Experimental patch to demonstrate drop shadows (incomplete!)

I'm attaching a patch that adds drop shadows to the Xft backend.
Comment 3 Marius Gedminas 2006-04-16 20:25:17 UTC
Created attachment 63660 [details]
Screenshot with the patch applied
Comment 4 Marius Gedminas 2006-04-16 20:26:02 UTC
Created attachment 63661 [details]
Screenshot without the patch
Comment 5 Behdad Esfahbod 2006-04-16 23:07:34 UTC
Looks nice.  Not sure how the performance penalty is.  And of course it does have the same problem as in bug #333157.
Comment 6 Chris Wilson 2007-01-26 22:24:56 UTC
Created attachment 81301 [details] [review]
Updated dropshadow patch.

Performance impact should be negligble as it defaults to off and require use of new API to turn it on.

But it looks nice ;)
Comment 7 Behdad Esfahbod 2007-01-27 19:48:10 UTC
How is the color of the shadow set?

Note that gdk has a similar effect that can be set using the embossed attribute.  We should check it out.
Comment 8 Chris Wilson 2007-01-27 22:00:27 UTC
Couldn't see how they choose the colour for the embossed text, but the technique is similar: redraw the text offset by +1,+1.

The color chosen to for the drop shadow is the background colour at ~50% opacity - which is just enough for the text to stand out on a strong pixmap background. The drop shadow is ignored if the cell actually has its own bg colour defined.
Comment 9 Behdad Esfahbod 2007-01-27 22:08:29 UTC
Gtk+ HEAD has API to set the emboss color.
Comment 10 Behdad Esfahbod 2007-11-28 13:26:53 UTC
Any update?
Comment 11 Christian Persch 2008-11-22 14:32:42 UTC
Comment on attachment 63659 [details] [review]
Experimental patch to demonstrate drop shadows (incomplete!)

Setting patch status; this patch is for the XFT backend which has been removed.
Comment 12 Christian Persch 2008-11-22 14:33:40 UTC
Doesn't apply cleanly, and needs to be updated to actually implement this in the pangocairo backend.
Comment 13 Christian Persch 2012-10-08 22:50:33 UTC
Don't think this makes sense since vte-next doesn't have transparency or image backgrounds.
Comment 14 Christian Persch 2015-12-26 12:34:45 UTC
Closing as per comment 13.